Adding standard names for chemical number densities, new rules about naming chemical species #125
Conversation
mkavulich
requested review from
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mattldawson,
mwaxmonsky,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
|
@cabarton @areinecke FYI - please look at the StandardNamesRules.rst and standard_names.xml only, the yaml and md files are auto-generated from the xml file. |
|
Seems reasonable to me. Do we need to have ion species and electrons added to the standard names list as well? |
|
@jeromebarre You have asked to review chemistry-related changes in the past; what do you think about these proposed chemical naming rules? |
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Approving but please look into clarifying the section with my question.
StandardNamesRules.rst
Outdated
| unambiguous common names (e.g. water, ozone) are also included. In all cases, the long name | ||
| should include specific details about the substance's chemical makeup, as well as the | ||
| phase/state of matter if relevant; e.g. ``water_vapor``, ``liquid_h2so4`` |
There was a problem hiding this comment.
In this sentence, are water_vapor and liquid_h2so4 supposed to be standard name examples or long name examples? The context leads me to think they are for standard names but in long names, we do not usually use underscores.
There was a problem hiding this comment.
@gold2718 Thanks for catching this, I did mean the standard name not long name here.
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Mostly looks good to me, but I did have one question/concern related to the new ion-naming rules.
|
Also tagging @mer-a-o in case she has an opinion on this PR. |
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for the naming rule change @mkavulich! Everything looks great to me now.
|
Given that we have not heard any objections after several requests for comment, we will move forward with this PR as is despite not having explicit approvals from all organizations. Please feel free to open an issue or discussion item if you have questions or concerns. |
6 participants
Description
This PR adds standard names for the number density of specific chemicals and their climatological values. These names are derived from discussion on Issue #112.
This also includes new rules regarding the naming of chemical species in standard names. These are my attempt at a draft of these rules and I welcome any feedback, corrections, or suggested changes, especially from anyone with more knowledge of atmospheric/geochemistry.
Issues
Resolves #112