Drop redundant patch and fixup command logging #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't remove the second patch but maybe increase the iterations to an higher number. The patch fixes a crash exploit |
Contributor
Author
This seems as though it would require upwards of 10 iterations if not more. |
calcastor
force-pushed
the
remove-patches
branch
from
453ba82 to
8a1543f
Compare
calcastor
changed the title
Contributor
Author
|
This PR now just adds a copy of |
calcastor
force-pushed
the
remove-patches
branch
2 times, most recently
from
1eee071 to
afb4a8d
Compare
calcastor
force-pushed
the
remove-patches
branch
from
afb4a8d to
e48de51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the "Colour Console Messages" and "Limit CraftChatMessage iterations" patches.
The first of these is unnecessary after #148.
The second of these patches is problematic as it cuts off certain console logs such as when someone is opped by a player on the server or when someone is added to the whitelist by a player on the server following #148. Further, this patch had absolutely zero explanation as to what issue it is supposed to avoid or resolve when it was added.