Basic put/get Query record #98
Conversation
osipovartem
requested review from
DanCodedThis,
Vedin,
YaroslavLitvinov and
rampage644
| let parsed_start_time = Self::parse_start_time(&query.start_time)?; | ||
| let pk = Self::query_pk(&parsed_start_time); | ||
| let sk = Self::query_sk(&parsed_start_time); | ||
| let pk = Self::query_pk(&query.start_time); |
There was a problem hiding this comment.
while we have pk as start_time here? I assumed pk should be shorten to date for pk.
There was a problem hiding this comment.
Check the function query_pk
crates/state-store/src/models.rs
Outdated
| #[derive(Clone, Debug, Serialize, Deserialize)] | ||
| #[derive(Clone, Debug, Serialize, Deserialize, Default)] | ||
| pub struct Query { | ||
| pub query_id: String, |
There was a problem hiding this comment.
can we use strict data types?
pub query_id: Uuid,
There was a problem hiding this comment.
what about session_id, it's &str everywhere (but the value itself in uuid format)
There was a problem hiding this comment.
I mean all fields datatypes, which we want to see a part of inerface.
There was a problem hiding this comment.
Uuid is already there for query_id and request_id, the question about session_id.
in service we have &str as session_id, should we parse it to uuid for state store?
There was a problem hiding this comment.
Shortly I think it's worth to use strict type for persisted session_id as well. But it's up to you, I do not insist, especially if such datatype leads to significant efforts as of legacy code.
Added basic example how to create inital record
Changed types of timestamps
Current problem
GSI cannot work with nested json field for indexing, that's why we insert additional columns for Query
the record looks like