Adapt descriptive_names to new elements in EnergyModelsFlex #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 29, 2025 10:21
…orting to .svg-format.
…resolves warning and uses a standard julia library that is faster to load.
tillho
reviewed
Jan 5, 2026
src/descriptive_names.yml
Outdated
| CapacityCostLink: | ||
| cap: "Installed capacity" | ||
| cap_price: "Price of capacity usage" | ||
| cap_price_periods: "The number of sub periods of a year" |
There was a problem hiding this comment.
Technically, the sub periods are per investment period which does not necessarily correspond to one full year.
To make it more intuitive, we could also write something like "The number of sub-periods within an investment period in which capacity costs are incurred."
tillho
reviewed
Jan 5, 2026
tillho
left a comment
tillho
left a comment
There was a problem hiding this comment.
One minor comment about a descriptive name, otherwise thumbs up from my side :)
dqpinel
reviewed
Jan 12, 2026
dqpinel
approved these changes
Jan 13, 2026
tillho
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts descriptive_names to new elements in EnergyModelsFlex.
Related PR: EnergyModelsX/EnergyModelsFlex.jl#6