URenderPipeline: Fix blend state with default/mc shaders on 1.17-1.20.6, third try #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….6, third try There another bug in GlBlendState which cause the GlBlendState which we apply by enabling the shader to not actually be stored as the `activeBlendState`. See code comments for details. Since we now necessarily have access to the GlBlendState of the shader, this commit also simplifies our dummy call to merely enable that particular GlBlendState instead of binding and unbinding the entire shader. Linear: EM-3512
Traben-0
approved these changes
Dec 3, 2025
Contributor
Traben-0
left a comment
Traben-0
left a comment
There was a problem hiding this comment.
lgtm, the val name Shader_glBlendState is odd but makes sense in the context
Johni0702
deleted the
feature/em-3512-wardrobe-flashes-black-when-scrolling-on-featured-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is another bug in GlBlendState which causes the GlBlendState which we apply by enabling the shader to not actually be stored as the
activeBlendState.See code comments for details.
Since we now necessarily have access to the GlBlendState of the shader, this commit also simplifies our dummy call to merely enable that particular GlBlendState instead of binding and unbinding the entire shader.
Linear: EM-3512