Skip to content

Conversation

@agent462
Copy link
Contributor

Large playlists were overflowing into Lead Out and counting was not correct with large playlists.

Batch processing used var in a loop with setTimeout, causing JavaScript closure issues where all async callbacks referenced the final loop values instead of their intended values

Also fixed the main playlistInfo.total_items to count all items not just main.

Screenshot 2025-12-29 at 9 00 16 PM

@agent462
Copy link
Contributor Author

I discovered a secondary issue and provided a fix in this same branch.

Stale playlist data is not cleared from DOM tables on back. If you open a playlist, hit back, create new playlist, it will populate with the playlist you originally viewed.

@agent462 agent462 changed the title fix large playlists overflowing into the wrong section (lead out) fix large playlists overflowing into the wrong section (lead out), fix stale DOM data from being put in new playlists Dec 30, 2025
@OnlineDynamic
Copy link
Collaborator

I need to check with the xlights guys on the playlist total count.. i left it counting just the main playlist items as i think that is the logic being used by xlights when it pushes sequences into a playlist... agree doesnt seem correct but think thats because xlights doesn't think about leadin and outs... the DOM thing seems to be very browser specific.. as most browsers i'm not seeing it... only managed to reproduce by running chormium

@agent462
Copy link
Contributor Author

agent462 commented Jan 1, 2026

Sounds good. The DOM thing was on latest FF OSX for me. I just noticed it poking around testing various things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants