Allow slice reuse when building multiple fuse filters #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Failure: |
Contributor
Author
|
Sorry, forgot to amend the commit. |
Member
|
@RaduBerinde Looks fine now. Can you add a section in the README.md as to how it is meant to be used? |
Member
|
I'd prefer to have even just minimal documentation (two sentences would be enough). |
Contributor
Author
|
Done. Thanks for the review! |
This commit introduces `BinaryFuseBuilder` which allows reuse of all allocated slices to avoid GC overhead. A single builder can be used with different fingerprint sizes. Fixes FastFilter#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
BinaryFuseBuilderwhich allows reuse of allallocated slices to avoid GC overhead. A single builder can be used
with different fingerprint sizes.
Fixes #45