-
Notifications
You must be signed in to change notification settings - Fork 1
fix: add required repository argument for rulesets
#64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vedantthapa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly identifies and fixes an issue where the repository argument was missing for github_repository_ruleset, causing API errors. The changes are applied consistently across the module, its tests, and the example usage. My main feedback is to add a validation check to ensure the new repository variable is provided when ruleset_type is 'repository', which will make the module more robust and prevent future misconfigurations.
repository argumentrepository argument
repository argumentrepository argument for rulesets
This reverts commit 71cc7c9.
This reverts commit 71cc7c9.
Contrary to the
repositoryargument being optional in official docs, specifying it is crucial, else the URL for API call is malformed.See this failed run for example, the repository name is missing between
//. Here's the upstream Go SDK reference.