-
Notifications
You must be signed in to change notification settings - Fork 1
Fix errors when no GHAS repos found #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @bzarboni1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the GHAS policy check workflow where it would fail when no GitHub Advanced Security (GHAS) enabled repositories were present. The changes enhance the script's ability to gracefully handle scenarios where the repository listing command either returns no results or outputs an error, preventing workflow failures and ensuring continued operation. Additionally, a specific GitHub Action has been downgraded to a stable version to maintain compatibility and reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue where the workflow would fail if no GHAS-enabled repositories were found. The changes correctly capture potential errors from the CLI tool and handle them by providing a default empty list, preventing downstream jobs from failing. Additionally, the advanced-security/policy-as-code action is downgraded. My review includes a suggestion to improve the robustness of a shell command and a recommendation to document the reason for the action downgrade for future maintainability.
Signed-off-by: Ben Zarboni <ben.zarboni@focisolutions.com>
Pull request was closed
Clone of issue found in Foci repo:
https://github.com/foci-github-foundations/organizations/pull/254