Skip to content

Conversation

@sudqijawabreh
Copy link
Collaborator

@sudqijawabreh sudqijawabreh commented Apr 3, 2021

Proposed Changes

Port Information schema file to support sql server. It is responsible for retrieving database schema and getting query's parameters and output columns. Also modify unit tests to be compatible with sql server

@sudqijawabreh sudqijawabreh force-pushed the InformationSchemaSqlServer branch from 2efd26a to dc2e2f1 Compare April 3, 2021 19:00
@falfaddaghi
Copy link
Member

@sudqijawabreh curious how hard would it be to append and not replace ?
meaning add a new file for MSSQLServer?
I ask because if we decide to support both we would need to do that wouldnt we ?

()
else if not requiredParam.DataType.IsArray then
match requiredParam.DataType.Name with
| "bit" ->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@falfaddaghi this the only part that needs some thought to make it work for both postgres and sql server.

sudqijawabreh pushed a commit that referenced this pull request Aug 6, 2021
@sudqijawabreh sudqijawabreh force-pushed the InformationSchemaSqlServer branch 4 times, most recently from 9cb4ad2 to 890948f Compare August 9, 2021 09:59
@falfaddaghi falfaddaghi force-pushed the InformationSchemaSqlServer branch from 890948f to f246511 Compare February 12, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants