Skip to content

Use a more flexible health probe bind address to enable both IPv4 and… #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndebuhr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use a more flexible health probe bind address to enable both IPv4 and… #2388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func (o *Options) BindFlags(fs *flag.FlagSet) {
fs.StringVar(
&o.HealthProbeBindAddress,
"health-probe-bind-address",
"[::1]:9443",
"localhost:9443",
Copy link
Member

@johscheuer johscheuer Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion around the default in the PR that added this flag: #2340 (comment). We decided to keep the current default value to reduce the risk of breaking things for customers. I would propose to change the default in the helm chart and creating a GitHub issue to change the default before cutting the 3.0 release of the operator (probably next year).

Copy link

@jlemaes jlemaes Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, for us this ipv6 only port was a breaking change when upgrading the operator as it started crashing not being able to bind to ipv6.

Being ip version agnostic makes most sense to me, the metrics address is also configured like that.

"The address the operator binds to for health / readiness / liveness probes.",
)
fs.IntVar(
Expand Down