maintenance: Align coverage.sh with CI workflow #209
Conversation
Refactors the `coverage.sh` script to align its behavior, particularly for the Clang toolchain, with the CI coverage workflow. Key changes: - Sets the `LLVM_PROFILE_FILE` environment variable during the test phase for Clang to ensure correct collection of raw profile data, mirroring the CI setup. - Changes the default preset from `coverage-gcc` to `coverage-clang` to match the CI standard. - Adds HTML report generation for the Clang toolchain, bringing it to feature parity with the GCC preset within the script. - Simplifies the logic for the Clang path by removing irrelevant and incorrect GCC-specific staleness checks. - Improves the argument parsing to be more robust and reliable.
There was a problem hiding this comment.
Pull request overview
This PR refactors the coverage.sh script to align with the CI workflow by making Clang the default toolchain and ensuring proper LLVM profile data collection. The changes improve feature parity between GCC and Clang coverage presets while simplifying the Clang-specific logic.
Key changes:
- Switches default preset from
coverage-gcctocoverage-clangto match CI standards - Adds
LLVM_PROFILE_FILEenvironment variable configuration during test execution for proper profile data collection - Implements HTML report generation for Clang preset, achieving feature parity with GCC
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 82.01% 82.13% +0.12%
==========================================
Files 120 118 -2
Lines 2174 2211 +37
Branches 348 353 +5
==========================================
+ Hits 1783 1816 +33
- Misses 253 262 +9
+ Partials 138 133 -5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@jules Please address the Copilot review. Additionally, please ensure that coverage.sh operates correctly (including upload) when LLVM is used, and ensure the help text explains how to invoke the script for GCC vs LLVM-generated coverage. |
…rkflow. - Implements support for uploading LLVM/Clang coverage reports to Codecov. - Improves the help text to clarify the differences between the GCC and Clang workflows. - Adds validation for the --preset flag. - Changes the exit code to 1 when no commands are provided. - Improves comments and file URL generation.
|
Closed in favor of #212. |
Refactors the
coverage.shscript to align its behavior, particularly for the Clang toolchain, with the CI coverage workflow.Key changes:
LLVM_PROFILE_FILEenvironment variable during the test phase for Clang to ensure correct collection of raw profile data, mirroring the CI setup.coverage-gcctocoverage-clangto match the CI standard.