Skip to content

Use attributes instead of annotations #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mpdude wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use attributes instead of annotations #48

mpdude wants to merge 1 commit into from

Conversation

@mpdude
Copy link

@mpdude mpdude commented Dec 19, 2025 •
edited
Loading

This switches to using attributes in MinkContext as suggested in #46.

This change makes sense only after bumping PHP version requirements as suggested in #47.

aik099
aik099 approved these changes Dec 21, 2025
View reviewed changes
Copy link

@aik099 aik099 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also doesn't look like a BC break, because Behat 3.10 should work on PHP 7.2+.

But I'm not sure how PHP attributes would work on PHP 7.x.

@mpdude
Copy link
Author

mpdude commented Dec 21, 2025

Not at all. IMHO this should go in a PHP 8.1+ release

@aik099 aik099 mentioned this pull request Dec 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aik099 aik099 aik099 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpdude @aik099