-
Notifications
You must be signed in to change notification settings - Fork 96
#323 Add net 6.0 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
#323 Add net 6.0 #324
Conversation
fe3c4f8 to
7aa2332
Compare
8ad8712 to
7d95e33
Compare
a4eab82 to
90d1992
Compare
90d1992 to
3818404
Compare
5aca3c4 to
ff145e2
Compare
ff145e2 to
dea191c
Compare
dea191c to
4813dca
Compare
4813dca to
dc2436c
Compare
95babbf to
eb2a53a
Compare
eb2a53a to
a5107c6
Compare
a5107c6 to
e1610a7
Compare
e1610a7 to
4ce440e
Compare
marcin-krystianc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thompson-tomo for your patience and apologies for the delay with this PR.
Initially, I was hesitant about this change because our test matrix in the CI wasn't ready for adding a new target framework. Also, adding a new target framework to the library expands the API surface of the library that we need to make sure is tested.
But we've decided now that adding new tfms is inevitable, so we are going to move forward with this change.
-
Since
.net6.0is already out of support, should we update this PR to use net8.0 instead (current LTS)? -
Please add an older target framework (I guess the previous LTS, which is
net6.0) to the test project so we are able to run tests fornetstandard2.0. -
Please update the CI matrix so we run tests for
net461,net.6.0, andnet8.0.
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
4ce440e to
9679f01
Compare
Adds in net 6.0 so that Microsoft.CSharp is no longer required as a dependency and improve cancellation propagation
Closes #323