Skip to content

Conversation

@thompson-tomo
Copy link

@thompson-tomo thompson-tomo commented May 12, 2024

Adds in net 6.0 so that Microsoft.CSharp is no longer required as a dependency and improve cancellation propagation

Closes #323

@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from fe3c4f8 to 7aa2332 Compare May 14, 2024 11:06
@thompson-tomo thompson-tomo changed the title #323 Add net standard 2.1 #323 Add net 6.0 May 15, 2024
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch 3 times, most recently from 8ad8712 to 7d95e33 Compare May 15, 2024 23:49
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch 2 times, most recently from a4eab82 to 90d1992 Compare July 14, 2024 00:32
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from 90d1992 to 3818404 Compare July 18, 2024 22:07
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from 5aca3c4 to ff145e2 Compare August 2, 2024 03:17
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from ff145e2 to dea191c Compare October 26, 2024 22:40
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from dea191c to 4813dca Compare November 8, 2024 12:03
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from 4813dca to dc2436c Compare January 2, 2025 10:22
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from 95babbf to eb2a53a Compare May 3, 2025 02:27
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from eb2a53a to a5107c6 Compare May 10, 2025 05:50
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from a5107c6 to e1610a7 Compare July 17, 2025 11:23
@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from e1610a7 to 4ce440e Compare October 18, 2025 05:08
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thompson-tomo for your patience and apologies for the delay with this PR.

Initially, I was hesitant about this change because our test matrix in the CI wasn't ready for adding a new target framework. Also, adding a new target framework to the library expands the API surface of the library that we need to make sure is tested.

But we've decided now that adding new tfms is inevitable, so we are going to move forward with this change.

  • Since .net6.0 is already out of support, should we update this PR to use net8.0 instead (current LTS)?

  • Please add an older target framework (I guess the previous LTS, which is net6.0) to the test project so we are able to run tests for netstandard2.0.

  • Please update the CI matrix so we run tests for net461, net.6.0, and net8.0.

@thompson-tomo thompson-tomo force-pushed the chore/#323_AddNetStandard2.1 branch from 4ce440e to 9679f01 Compare October 23, 2025 09:01
@marcin-krystianc marcin-krystianc added the help wanted Extra attention is needed label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional TFM So Microsoft.CSharp can be externalised

3 participants