Feature/ai abilities api #1204
Draft
Feature/ai abilities api #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (list/create/update events & venues, calculate-dates). Enables natural language event management via WordPress REST API.
PR Summary
|
Contributor
|
@jmarx quick notes:
This looks great! Thx! |
…ility Adds get_calculate_dates_ability() method that checks for ai/calculate-dates ability from external AI plugin and falls back to gatherpress/calculate-dates if not available. This allows GatherPress to use the external plugin's date calculator when available.
…s:ignore comments
mauteri
reviewed
Jan 2, 2026
| // Handle relative patterns first (next, last, this, tomorrow, yesterday). | ||
| $relative_weekday_pattern = '/^(next|last|this)\s+' | ||
| . '(monday|tuesday|wednesday|thursday|friday|saturday|sunday)$/i'; | ||
| if ( preg_match( $relative_weekday_pattern, $pattern_low, $matches ) ) { |
Contributor
There was a problem hiding this comment.
Something like this would be a cleaner approach than this super long if/elseif statement.
private function get_pattern_handlers(): array {
return [
'/^(next|last|this)\s+(monday|tuesday|...)$/i' => 'handle_relative_weekday',
'/^(tomorrow|yesterday)$/i' => 'handle_relative_day',
// ...
];
}
private function calculate_recurring_dates( string $pattern, int $occurrences, \DateTime $start ): array {
foreach ( $this->get_pattern_handlers() as $regex => $method ) {
if ( preg_match( $regex, $pattern, $matches ) ) {
return $this->$method( $matches, $occurrences, $start );
}
}
return array();
}
mauteri
reviewed
Jan 2, 2026
| private function get_nth_weekday_of_month( int $year, int $month, string $weekday, int $nth ): string { | ||
| if ( -1 === $nth ) { | ||
| // Last occurrence. | ||
| $date = new \DateTime( "last {$weekday} of {$year}-{$month}" ); |
Contributor
There was a problem hiding this comment.
Add use DateTime at top of file and call new DateTime (here and everywhere)
mauteri
reviewed
Jan 2, 2026
| private function get_gatherpress_functions() { | ||
| // Check if external AI plugin's calculate-dates ability is available. | ||
| // If so, use it instead of GatherPress's own implementation. | ||
| $calculate_dates_ability = Abilities_Integration::get_calculate_dates_ability(); |
Contributor
There was a problem hiding this comment.
seems variable is only used once, so no need to set the variable, just include it in the array.
mauteri
reviewed
Jan 2, 2026
| 'tool_choice' => 'auto', | ||
| ); | ||
|
|
||
| $response = wp_remote_post( |
mauteri
reviewed
Jan 2, 2026
|
|
||
| // Max iterations reached. | ||
| return array( | ||
| 'response' => 'Task partially completed. Maximum iterations reached.', |
Contributor
There was a problem hiding this comment.
Does this need translation function?
mauteri
reviewed
Jan 2, 2026
| ), | ||
| ); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I would make the AI Experiments plugin a dependency of this feature. Not sure when/if that code is making it into core eventually. But we should be utilizing core settings when we can and not including our own settings of the same thing. Maybe get some guidance here from @jeffpaul
Collaborator
Author
There was a problem hiding this comment.
@mauteri very hard disagree. But just wait a bit for my latest stuff :) I'll explain what im doing
mauteri
reviewed
Jan 2, 2026
| $status.show(); | ||
|
|
||
| // Send to backend | ||
| $.ajax( { |
Contributor
There was a problem hiding this comment.
Change to REST API and use apiFetch
mauteri
reviewed
Jan 2, 2026
| @@ -0,0 +1,168 @@ | |||
| .gp-ai-assistant { | |||
Contributor
There was a problem hiding this comment.
Need to prepend with gatherpress- not gp-
mauteri
reviewed
Jan 2, 2026
| ), | ||
| utility_style: path.resolve( process.cwd(), 'src', 'utility.scss' ), | ||
| 'ai-assistant': path.resolve( process.cwd(), 'src/ai', 'index.js' ), | ||
| 'ai-assistant-style': path.resolve( process.cwd(), 'src/ai', 'style.scss' ), |
Contributor
There was a problem hiding this comment.
use underscores to keep format.
- Extract and return model/provider metadata from AI responses - Display model info (provider and model name) in AI Assistant UI with styling - Add admin notice on wp-ai-client settings page recommending OpenAI - Update font size for model info display to 13px
- Test MAX_ITERATIONS constant - Test process_prompt with various error conditions - Test has_api_key method with different scenarios - Test get_gatherpress_abilities method - Test function_name_to_ability_name conversion - Test method existence for private methods using reflection - All 20 tests pass (3 skipped when dependencies not available)
- Fix line length issues by breaking long lines - Add @throws tag to process_conversation_loop method - Add phpcs:ignore for empty catch block with explanation - Add phpcs:ignore for translation strings that exceed line length - Fix inline comment punctuation - All errors resolved, warnings suppressed with appropriate comments
- Fix empty catch block by adding code (set provider_name to empty string) - Fix line length issues by shortening translation strings - Add @throws tag to process_conversation_loop method - Fix inline comment punctuation - All errors and warnings resolved (0 errors, 0 warnings)
- Break long translation string across multiple lines - All linting issues resolved for class-setup.php
…s test, remove old test files
…, init_wp_ai_client, increase_ai_request_timeout)
…comments for WP_Ability
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#1204 with the following PHP versions: PHP Version 8.4
PHP Version 8.2
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: