Add ISM functions and update tutorial #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avantikalal
requested changes
Jul 29, 2024
| Args: | ||
| ism (np.ndarray): The ISM array | ||
| scan (pd.DataFrame): The motif scan DataFrame |
Collaborator
There was a problem hiding this comment.
Let's specify which functions create ism and scan
| rolling_max_ism = _moving_average(max_ism, n=rolling_buffer) | ||
|
|
||
| # Create plot | ||
| plt.figure(figsize=(10, 4), dpi=200) |
Collaborator
There was a problem hiding this comment.
Can we implement this in plotnine for consistency with the rest of the package?
| return scan | ||
|
|
||
|
|
||
| def calculate_ism_weight(row: pd.Series, ism: np.ndarray) -> float: |
Collaborator
There was a problem hiding this comment.
Currently, we average the ISM values over the motif without accounting for whether the shape of the ISM signal (i.e. relative score of different nucleotides at the position) matches that of the motif. Wouldn't it be better if we convolved the ISM matrix with the motif matrix - e.g. using np.convolve or scipy.signal.convolve?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds ISM scoring to motifs.
Updated
src/grelu/interpret/motifs.py:calculate_ism_weightfunction to compute ISM weights across the scan motif DataFrame.Updated
src/grelu/visualize.py:_moving_averagefunction for calculating moving averages of arrays.plot_motifs_on_ismfunction to visualize motifs on ISM data.Updated
docs/tutorials/5_variant.ipynb:Potential todo: draw motif logos on plot.
Testing: