feat: add configurable HTTP timeouts for API requests #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement appropriate timeout values for different API operations: - Single geocoding requests: 5 seconds - Batch geocoding requests: 30 minutes - Lists API requests: 60 seconds This prevents requests from hanging indefinitely and provides reasonable limits based on the expected duration of each operation type.
- Add instance properties to store timeout configurations
- Add setter methods to customize timeout values per instance
- Update all API methods to use instance properties instead of constants
- Add comprehensive tests to verify timeouts are properly passed to Guzzle
This allows users to configure timeout values based on their specific needs:
```php
$geocodio->setSingleTimeoutMs(10000) // 10 seconds
->setBatchTimeoutMs(3600000) // 1 hour
->setListsTimeoutMs(120000); // 2 minutes
```
sixlive
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds configurable HTTP timeout values to prevent API requests from hanging indefinitely and to provide appropriate limits based on the expected duration of different operation types.
Changes
Geocodioclass for different operation typesSendsRequeststrait to accept and apply timeout parameters to Guzzle requestsgeocode()method to use 5-second timeout for single requests and 30-minute timeout for batch requestsreverse()method to use 5-second timeout for single requests and 30-minute timeout for batch requestsuploadList,uploadInlineList,listStatus,lists,downloadList,deleteList) to use 60-second timeoutTest Plan
Tests\GeocodingTestsuite validates geocoding operations with new timeoutsTests\ListTestsuite validates list operations with new timeoutsTests\ErrorHandlingTestsuite ensures error handling still works correctly