Allow implementors to inject and interact with custom scripts #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed inexistent test target for successful build. * Fix for crashed cause when alert is presented outside of view hierarchy. * Return early and also call the completionHandlers if the view is not in hierarchy.
* Removed inexistent test target for successful build. * Added WebInteractionDelegate to DriveController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WebInteractionDelegateprotocol, with default empty implementations.ScriptInjectableprotocol, to which implementing viewControllers or class types can conform and then register their own custom scripts.registerInjectableScriptandunregisterScriptInjectablefor implementors to call when wanting to add or delete existing custom scripts.testTargetpart from thePackage.swift, because I could not build the package in Xcode 14.1, as there was no testTarget in the package.