Various improvements #561
Merged
Various improvements #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens often when hitting ^C, but did not happen when I committed this code originally. Possibly the cause is the use of a newer Python version.
This significantly improves throughput, in particular with `recv`.
By default (without a send buffer configured), the `write` call never blocks, and there scarcely be a reason for it to block on a modern system that can process many more packets with much more data than we can put into it. However, by using the loop to detect readiness, this function would incur latency in the calling asyncio task each time it was used, even if the write would succeed, which impacted throughput.
Wide counters (24-bit and wider) are problematic on the fairly slow iCE40 architecture, and this module allows using counters of any width by pipelining them. Co-authored-by: Wanda <wanda@phinode.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollup PR of several pending improvements that I have:
asignalbug which would sometimes show a backtrace on ^Cregistersmodule that improves compatibility with components and reduces boilerplate, extracted from [Addon in validation] Add Ram-Pak support #483