Modernize applet program-nrf24lx1
#927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
added
the
waiting-on-author
"Mode" has a specific meaning in context of SPI which this enum did not reflect. QSPI does not have the same "mode", but is also changed for consistency.
The reasoning is explained in the next commit.
The SPI controller gains an additional usage constraint: when changing modes (the default is Mode 0), you must perform an idle operation with the new mode before transferring any data. (Obviously, changing mode while a device is selected is not supported.)
whitequark
force-pushed
the
modernize-program-nrf24lx1
branch
from
1720785 to
24e2e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently broken because at least the LU1 device requires SPI Mode 0, and we implement Mode 3 only.