Skip to content

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Mar 28, 2024

This PR contains the following updates:

Package Change Age Confidence
express (source) 4.18.24.20.0 age confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with express@4.19.0, we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

Resources

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: serve-static@​0.16.0
    • Remove link renderization in html while redirecting
  • deps: send@​0.19.0
    • Remove link renderization in html while redirecting
  • deps: body-parser@​0.6.0
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: path-to-regexp@​0.1.10
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source

==========

  • Prevent open redirect allow list bypass due to encodeurl
  • deps: cookie@​0.6.0

v4.18.3

Compare Source

==========

  • Fix routing requests without method
  • deps: body-parser@​1.20.2
    • Fix strict json error message on Node.js 19+
    • deps: content-type@~1.0.5
    • deps: raw-body@​2.5.2
  • deps: cookie@​0.6.0
    • Add partitioned option

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner March 28, 2024 16:28
@forking-renovate forking-renovate bot added the automerge Merge the pull request once unit tests and other checks pass. label Mar 28, 2024
@dpebot
Copy link
Collaborator

dpebot commented Mar 28, 2024

/gcbrun

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 28, 2024
@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from 132f510 to 2ddc167 Compare March 29, 2024 07:51
@dpebot
Copy link
Collaborator

dpebot commented Mar 29, 2024

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from 2ddc167 to 4028a44 Compare June 4, 2024 11:00
@dpebot
Copy link
Collaborator

dpebot commented Jun 4, 2024

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from 4028a44 to cd9ba6c Compare September 17, 2024 01:18
@renovate-bot renovate-bot changed the title fix(deps): update dependency express to v4.19.2 [security] fix(deps): update dependency express to v4.20.0 [security] Sep 17, 2024
@dpebot
Copy link
Collaborator

dpebot commented Sep 17, 2024

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from cd9ba6c to 55e8616 Compare December 2, 2024 08:12
@dpebot
Copy link
Collaborator

dpebot commented Dec 2, 2024

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from 55e8616 to e372370 Compare January 23, 2025 20:04
@dpebot
Copy link
Collaborator

dpebot commented Jan 23, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from e372370 to aef1b45 Compare February 9, 2025 15:12
@dpebot
Copy link
Collaborator

dpebot commented Feb 9, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from aef1b45 to 733e37c Compare March 3, 2025 14:37
@dpebot
Copy link
Collaborator

dpebot commented Mar 3, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from 733e37c to aefd06c Compare March 11, 2025 15:38
@dpebot
Copy link
Collaborator

dpebot commented Mar 11, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from aefd06c to cf48c33 Compare April 17, 2025 00:35
@renovate-bot renovate-bot requested a review from a team as a code owner April 17, 2025 00:35
@dpebot
Copy link
Collaborator

dpebot commented Apr 17, 2025

/gcbrun

@glasnt glasnt removed the request for review from a team April 17, 2025 02:29
@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from cf48c33 to 7fac71e Compare May 28, 2025 23:04
@dpebot
Copy link
Collaborator

dpebot commented May 28, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from 7fac71e to fac85b2 Compare September 25, 2025 18:39
@dpebot
Copy link
Collaborator

dpebot commented Sep 25, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-express-vulnerability branch from fac85b2 to bdb29a4 Compare October 8, 2025 23:55
@dpebot
Copy link
Collaborator

dpebot commented Oct 8, 2025

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants