Add -cprof_service_account_json_file flag for explicit credential path #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupuletic
force-pushed
the
add-service-account-json-file-flag
branch
from
58219c1 to
a62cbf0
Compare
…ding Replace environment variable manipulation with direct use of gRPC's ServiceAccountJWTAccessCredentials API. This eliminates race conditions from concurrent credential initialization and avoids global state pollution. Changes: - Add ReadFileContents() helper with path validation - Read service account JSON directly and create JWT credentials - Compose SSL and call credentials using CompositeChannelCredentials - Preserve ADC fallback when flag not specified - Remove all setenv/unsetenv/getenv calls This ensures thread-safe credential initialization and follows gRPC best practices for service account authentication.
lupuletic
force-pushed
the
add-service-account-json-file-flag
branch
from
a62cbf0 to
ae73536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Add -cprof_service_account_json_file flag for explicit credential path
Description:
This PR adds a new flag
-cprof_service_account_json_filethat allows users to specify a custom service account JSON file path for authentication.Motivation
When running the profiler on-premises or in environments where the application already uses
GOOGLE_APPLICATION_CREDENTIALSfor a different Google Cloud service, there's no way toprovide separate credentials for the profiler.
Changes
-cprof_service_account_json_fileExample Usage
Use Cases
Testing
Tested with a Java application that uses separate credentials for: