Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented Dec 18, 2025

With #13596, we both added Python 3.14, but also removed python 2.7 from the base testing image.

The way testing is currently setup, while most tests (apart from App Engine Standard) are configured to skip Python 2.7, nox only handles this skip within the versioned environment.

For example, previously these checks would show:

cp /workspace/noxfile-template.py noxfile.py
cd path/to/sample
nox -s py-2.7
nox > Running session py-2.7
nox > Creating virtual environment (virtualenv) using python2.7 in .nox/py-2-7
nox > Session py-2.7 skipped: SKIPPED: 2.7 tests are disabled for this sample..

Since the merge of 13596, these now appear as:

cd path/to/sample
nox -s py-2.7
nox > Running session py-2.7
nox > Session py-2.7 failed: Python interpreter 2.7 not found.

With the deprecation of Python 2.7 for App Engine Standard first-generation just over 6 weeks away, we should be able to remove this version from our Nox and Kokoro configurations, thus preventing this failing error.

Additionally, since the copy of noxfile-template in App Engine Standard was primarily there because of Python 2.7, this forked version has been deleted.

⚠️ As a temporary workaround, the "Kokoro CI - Python 2.7 (App Engine Standard Only)" test has been removed as being "Required" to allow a PR to be merged.

  • Confirm cl/846023750 resolved
  • Please merge this PR for me once it is approved

This file should be no longer required since the only difference was 2.7
@glasnt glasnt requested review from a team as code owners December 18, 2025 02:29
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Dec 18, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the removal of Python 2.7 support from the project's testing infrastructure. Following a previous update that removed Python 2.7 from the base testing image, this change updates the Nox configuration to no longer include Python 2.7 in the list of tested versions, preventing test failures due to missing interpreters. Additionally, a Python 2.7-specific Noxfile template for App Engine Standard has been removed.

Highlights

  • Python 2.7 Removal: Python 2.7 has been explicitly removed from the ALL_VERSIONS list in noxfile-template.py, aligning with its prior removal from the base testing image and upcoming deprecation for App Engine Standard.
  • App Engine Standard Noxfile Deletion: The appengine/standard/noxfile-template.py file, which was primarily maintained for Python 2.7 testing within App Engine Standard, has been completely removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes Python 2.7 from the tested versions to align with its deprecation and removal from the testing environment. The changes, which include updating ALL_VERSIONS in noxfile-template.py and deleting the specialized appengine/standard/noxfile-template.py, are logical and directly address the issue of failing builds. The implementation is sound and I have no concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants