-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat!: remove Python 2.7 from tested versions #13675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This file should be no longer required since the only difference was 2.7
Summary of ChangesHello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request finalizes the removal of Python 2.7 support from the project's testing infrastructure. Following a previous update that removed Python 2.7 from the base testing image, this change updates the Nox configuration to no longer include Python 2.7 in the list of tested versions, preventing test failures due to missing interpreters. Additionally, a Python 2.7-specific Noxfile template for App Engine Standard has been removed. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes Python 2.7 from the tested versions to align with its deprecation and removal from the testing environment. The changes, which include updating ALL_VERSIONS in noxfile-template.py and deleting the specialized appengine/standard/noxfile-template.py, are logical and directly address the issue of failing builds. The implementation is sound and I have no concerns.
With #13596, we both added Python 3.14, but also removed python 2.7 from the base testing image.
The way testing is currently setup, while most tests (apart from App Engine Standard) are configured to skip Python 2.7, nox only handles this skip within the versioned environment.
For example, previously these checks would show:
Since the merge of 13596, these now appear as:
With the deprecation of Python 2.7 for App Engine Standard first-generation just over 6 weeks away, we should be able to remove this version from our Nox and Kokoro configurations, thus preventing this failing error.
Additionally, since the copy of noxfile-template in App Engine Standard was primarily there because of Python 2.7, this forked version has been deleted.