-
-
Notifications
You must be signed in to change notification settings - Fork 12
added release state display to info app #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
added release state display to info app #56
Conversation
|
So this checks for which model you have and fetched the values for your own device? What channel a release is in can differ per device. |
|
Yes, that's right. https://releases.grapheneos.org/husky-stable and parses the release number from each request and shows it in the according box. Would be great if someone could verify that android.os.Build.BOARD really gives the right model name 😄 |
|
Thanks. We'll get around to looking at this soon. |
It does currently, but is not guaranteed to be set to the required value for future devices. |
Thank you 🙂 I have changed it to this variable |
|
Needs to be rebased due to various conflicting changes. |
|
Made a rebase and should be compatible with the current main again :) |
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleaseState.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleaseState.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleaseState.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleasesViewModel.kt
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleasesViewModel.kt
Outdated
Show resolved
Hide resolved
|
Thanks :) I have resolved all your mentioned things in my code. @soupslurpr |
soupslurpr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. It needs a few more changes and then it should be ready to be merged.
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleasesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleaseState.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleasesScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleaseState.kt
Outdated
Show resolved
Hide resolved
|
Thanks again for the feedback :) Should be resolved now @soupslurpr |
|
Just another edit: I have noticed that I haven't added updateReleaseStates to Lifecycle.Event.ON_START and to the PullToRefreshBox. |
soupslurpr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and adding that. It mostly looks good now, there's just one thing I'm unsure of.
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleasesScreen.kt
Outdated
Show resolved
Hide resolved
|
Thanks for the idea :) I think I also got this working now @soupslurpr |
soupslurpr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me now! Thank you for the contribution.
|
Happy to help :) And thanks again for your feedback! :) |
|
So, is there any estimation when this probably could get merged? 🙂 |
|
So, just kindly want to bump this PR up :) Anything I should do before it can be merged? |
|
We have a lot of very high priorities and many recent PRs we've merged have caused issues resulting in needing to make unplanned emergency releases. It's not really a good time to be merging things we don't consider high priority. |
|
Thanks for the feedback :) Totally understandable! I will keep the PR updated from time to time if the main changes and maybe there comes a better time for merging it. Thanks again and also thanks for your awesome work! |
I tried to add a release state to the release notes tab in the info app.
It should look like this:
It fetches the current release state by using the android.os.Build.BOARD constant for stable, beta and alpha by constructing the url https://releases.grapheneos.org/$board-$releasePhase
Feedback is very much welcomed as these are my first steps in kotlin 😄