Skip to content

Conversation

@DirkBaumeister
Copy link

I tried to add a release state to the release notes tab in the info app.

It should look like this:

Bildschirmfoto 2024-10-22 um 21 53 19

It fetches the current release state by using the android.os.Build.BOARD constant for stable, beta and alpha by constructing the url https://releases.grapheneos.org/$board-$releasePhase

Feedback is very much welcomed as these are my first steps in kotlin 😄

@matchboxbananasynergy
Copy link
Contributor

So this checks for which model you have and fetched the values for your own device? What channel a release is in can differ per device.

@DirkBaumeister
Copy link
Author

Yes, that's right.
As long as android.os.Build.BOARD gives the correct device name (husky for Pixel 8 Pro) for example it checks for the specific releases for this model the app is running on.
In the case of the Pixel 8 Pro it fetches for example the following urls:

https://releases.grapheneos.org/husky-stable
https://releases.grapheneos.org/husky-beta
https://releases.grapheneos.org/husky-alpha

and parses the release number from each request and shows it in the according box.

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name 😄

@matchboxbananasynergy
Copy link
Contributor

Thanks. We'll get around to looking at this soon.

@muhomorr
Copy link
Member

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name

It does currently, but is not guaranteed to be set to the required value for future devices. android.os.Build.DEVICE is the right variable to check for this use-case AFAIK.

@DirkBaumeister
Copy link
Author

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name

It does currently, but is not guaranteed to be set to the required value for future devices. android.os.Build.DEVICE is the right variable to check for this use-case AFAIK.

Thank you 🙂 I have changed it to this variable

@thestinger
Copy link
Member

Needs to be rebased due to various conflicting changes.

@DirkBaumeister
Copy link
Author

Made a rebase and should be compatible with the current main again :)

@DirkBaumeister
Copy link
Author

Thanks :) I have resolved all your mentioned things in my code. @soupslurpr

Copy link
Member

@soupslurpr soupslurpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It needs a few more changes and then it should be ready to be merged.

@DirkBaumeister
Copy link
Author

Thanks again for the feedback :) Should be resolved now @soupslurpr

@DirkBaumeister
Copy link
Author

Just another edit: I have noticed that I haven't added updateReleaseStates to Lifecycle.Event.ON_START and to the PullToRefreshBox.
It's now implemented like updateChangelog is. Can you please check if it is done right this way? @soupslurpr

Copy link
Member

@soupslurpr soupslurpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and adding that. It mostly looks good now, there's just one thing I'm unsure of.

@DirkBaumeister
Copy link
Author

Thanks for the idea :) I think I also got this working now @soupslurpr

Copy link
Member

@soupslurpr soupslurpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now! Thank you for the contribution.

@DirkBaumeister
Copy link
Author

Happy to help :) And thanks again for your feedback! :)

@DirkBaumeister
Copy link
Author

So, is there any estimation when this probably could get merged? 🙂

@DirkBaumeister
Copy link
Author

DirkBaumeister commented Sep 30, 2025

So, just kindly want to bump this PR up :) Anything I should do before it can be merged?

@thestinger
Copy link
Member

We have a lot of very high priorities and many recent PRs we've merged have caused issues resulting in needing to make unplanned emergency releases. It's not really a good time to be merging things we don't consider high priority.

@DirkBaumeister
Copy link
Author

Thanks for the feedback :) Totally understandable! I will keep the PR updated from time to time if the main changes and maybe there comes a better time for merging it. Thanks again and also thanks for your awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants