Serde Package #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
karnishein
reviewed
Dec 3, 2025
karnishein
left a comment
karnishein
left a comment
There was a problem hiding this comment.
I have no idea how you expect me to do this well
yoavs8
approved these changes
Dec 3, 2025
…ons into the correct object form
yuval20100
reviewed
Dec 7, 2025
Kovler10
requested changes
Dec 14, 2025
packages/serde/index.ts
Outdated
Comment on lines
22
to
23
| const binaryTrueValue = 1; | ||
| const binaryModulus = 2; |
There was a problem hiding this comment.
avoid using magic numbers. move to a consts file
packages/serde/index.ts
Outdated
|
|
||
| const binaryTrueValue = 1; | ||
| const binaryModulus = 2; | ||
| // TODO add signed support! |
There was a problem hiding this comment.
document this somewhere else then the code
| @@ -0,0 +1,62 @@ | |||
| // בס"ד | |||
|
|
|||
There was a problem hiding this comment.
make sure you actually need this file. is there a built-in type or an NPM package you can use instead
Comment on lines
+8
to
+10
| export const bitArrayLength = 8; | ||
| const singleShift = 1; | ||
| const shouldntInsert = 0; |
Comment on lines
+8
to
+10
| export const bitArrayLength = 8; | ||
| const singleShift = 1; | ||
| const shouldntInsert = 0; |
There was a problem hiding this comment.
the name is for a boolean and the value is a number.
packages/serde/index.ts
Outdated
| // TODO add signed support! | ||
| export const serdeUnsignedInt = (bitCount: number): Serde<number> => ({ | ||
| serializer(serialiedData: BitArray, num: number) { | ||
| const arr = new BitArray(); |
There was a problem hiding this comment.
avoid using abbreviations. arr --> array and num --> number
| @@ -0,0 +1,264 @@ | |||
| // בס"ד | |||
There was a problem hiding this comment.
- extract every serialize and deserialize function to it's own function.
- add a unit test for every function (Optional for this PR can be in another task)
- split every de/serialize function to it's own file by the serialization type.
- create a Factory/Builder function to get the desired Serde when used.
- add a
Readme.mdfile explaining what a Serde is (GPT is great for this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is meant to compact data into a small string for small QR codes