Playoff Schedule #3

yoavs8 · 2025-12-07T15:29:23Z

the project makes a schedule for playoff and events that happened and will happen

apps/playoff-schedule/frontend/src/App.tsx

karnishein · 2025-12-07T15:41:18Z

apps/playoff-schedule/frontend/src/endpoints/unUsed/EventsFull.tsx

+// בס"ד
+// const eventsInYear = t.type({// if you need this
+//   address: t.string,
+//   city: t.string,
+//   country: t.string,
+//   district: t.unknown,
+//   division_keys: t.array(t.string),
+//   end_date: t.string,
+//   event_code: t.string,
+//   event_type: t.number,
+//   event_type_string: t.string,
+//   first_event_code: t.string,
+//   first_event_id: t.unknown,
+//   gmaps_place_id: t.string,
+//   gmaps_url: t.string,
+//   key: t.string,
+//   lat: t.number,
+//   lng: t.number,
+//   location_name: t.string,
+//   name: t.string,
+//   parent_event_key: t.unknown,
+//   playoff_type: t.number,
+//   playoff_type_string: t.string,
+//   postal_code: t.string,
+//   remap_teams: t.unknown,
+//   short_name: t.string,
+//   start_date: t.string,
+//   state_prov: t.string,
+//   timezone: t.string,
+//   webcasts: t.array(
+//     t.type({
+//       channel: t.string,
+//       type: t.string,
+//     })
+//   ),


if this is unused, why is this here?

karnishein · 2025-12-07T15:42:36Z

apps/playoff-schedule/frontend/start.ts

+
+app.use(express.static(distDirectory));
+
+app.get(/^(.*)$/, (req, res) => {


this is magic, I don't like magic

agreed, consider copying what is in the updated master branch. either look at it through github or git pull and merge

YoniKiriaty

Thought this was good then I saw the App.tsx

YoniKiriaty · 2025-12-09T19:50:10Z

.vscode/tasks.json

      "type": "shell",
-      "command": "./node_modules/.bin/dotenv -e .dev.env -e .public.env -e .secret.env -- 'turbo run dev --filter=${input:project}-frontend --filter=${input:project}-backend'"
+      "command": "./node_modules/.bin/dotenv -e .dev.env -e .public.env -e .secret.env -- 'turbo run dev --filter=${input:project}-frontend --filter=${input:project}-backend'",
+      "problemMatcher": []


consider removing this.

YoniKiriaty · 2025-12-09T19:53:02Z

apps/playoff-schedule/backend/src/main.ts

+const statusBadServer = 500;
+const statusGood = 200;
+const statusBadUser = 400;


consider using the status codes library http-status-codes:
use StatusCodes.OK instead of statusGood

YoniKiriaty · 2025-12-09T19:59:39Z

apps/playoff-schedule/backend/src/main.ts

+const statusBadUser = 400;
+
+// enter a valid api key
+const apiKey = "YOUR_API_KEY";


consider using enviromental variables to pass in sensitive information. create a .secret.env file near the .public.env file (the .secret.env file is already gitignored and used in the files). consider looking at the .public.env at how to make enviromental variables.

Suggested change

const apiKey = "YOUR_API_KEY";

const apiKey = process.env.TBA_API_KEY ?? "YOUR_API_KEY";

YoniKiriaty · 2025-12-09T20:01:50Z

apps/playoff-schedule/backend/src/main.ts

+export const fetchData = async (url: string): Promise<unknown> => {
+  const response = await fetch(url, {
+    method: "GET",
+    headers: {
+      "X-TBA-Auth-Key": apiKey,
+      "Content-Type": "application/json",
+    },
+    mode: "cors",
+  });
+  if (!response.ok) {
+    throw new Error(`HTTP error! status: ${response.status}`);
+  }
+  const data = await response.json();
+  console.log("TBA data:", data);
+  return data;
+
+};
+
+
+app.get("/fetch", async (req, res) => {
+  try {
+    const encodedUrl = req.query.url;
+    if (!encodedUrl || typeof encodedUrl !== "string") {
+      res.status(statusBadUser).json({ error: "missing url param" });
+      return;
+    }
+    const fullUrl = decodeURIComponent(encodedUrl);
+    console.log("Incoming /fetch with url:", fullUrl);
+
+    const data = await fetchData(fullUrl);
+    res.status(statusGood).json(data);
+  } catch (error) {
+    console.error("Error in /fetch:", error);
+    res.status(statusBadServer).json({ error: "Failed to fetch data" });
+  }
+});


consider making a file called tba.ts in the routes directory, and use Router syntax to show the data. consider looking into how the index.ts in routes works and reading on it

YoniKiriaty · 2025-12-09T20:06:02Z

apps/playoff-schedule/backend/src/main.ts

+app.get("/fetch", async (req, res) => {
+  try {
+    const encodedUrl = req.query.url;
+    if (!encodedUrl || typeof encodedUrl !== "string") {
+      res.status(statusBadUser).json({ error: "missing url param" });
+      return;
+    }
+    const fullUrl = decodeURIComponent(encodedUrl);
+    console.log("Incoming /fetch with url:", fullUrl);
+
+    const data = await fetchData(fullUrl);
+    res.status(statusGood).json(data);
+  } catch (error) {
+    console.error("Error in /fetch:", error);
+    res.status(statusBadServer).json({ error: "Failed to fetch data" });
+  }
+});


getting the URL from the user and making a fetch with that can be pretty unsafe. a person can send malicious requests which will make you send requests he makes. consider making multiple get endpoints for different cases, for example an endpoint for matches, for teams and for event data.

YoniKiriaty · 2025-12-09T20:41:26Z

apps/playoff-schedule/frontend/src/App.tsx

+  const [teamRank, setTeamRank] = useState<RankItem | null>(null);
+  const [searchStatus, setSearchStatus] = useState<"idle" | "loading" | "success" | "error">("idle");
+
+  const resetInSearch = () => {


consider using useCallback

YoniKiriaty · 2025-12-09T20:42:14Z

apps/playoff-schedule/frontend/src/App.tsx

+  const sortMatches = useCallback((a: MatchesSimpleType, b: MatchesSimpleType) => {
+    const timeA = a.predicted_time ?? a.time ?? matchTimeDefault;
+    const timeB = b.predicted_time ?? b.time ?? matchTimeDefault;
+    const weightA = getLevelWeight(a.comp_level);
+    const weightB = getLevelWeight(b.comp_level);
+
+    return (timeA > matchTimeMissing && timeB > matchTimeMissing) ? timeA - timeB
+      : (timeA === matchTimeMissing && timeB > matchTimeMissing) ? sortABeforeB
+      : (timeA > matchTimeMissing && timeB === matchTimeMissing) ? sortBBeforeA
+      : (weightA !== weightB) 
+        ? weightA - weightB 
+        : a.match_number - b.match_number;
+  }, []);


can't this function be defined outside of the component?

YoniKiriaty · 2025-12-09T20:44:36Z

apps/playoff-schedule/frontend/src/App.tsx

+
+  useEffect(() => {
+    const intervalId: number | undefined = searchStatus === "success" && activeEventKey ? 
+      window.setInterval(() => {


consider not using window

YoniKiriaty · 2025-12-09T20:48:43Z

apps/playoff-schedule/frontend/src/App.tsx

+    const map: Map<string, string> = new Map();
+    teams.forEach(team => map.set(team.key, team.nickname));


consider using a Record<string,string> instead of a map.

Suggested change

const map: Map<string, string> = new Map();

teams.forEach(team => map.set(team.key, team.nickname));

const map: Record<string, string> = {};

teams.forEach(team => {map[team.key] = team.nickname;});

YoniKiriaty · 2025-12-09T20:49:06Z

apps/playoff-schedule/frontend/src/App.tsx

+  const { currentGlobalMatch, targetTeamMatches, isEventOver, isTeamDone, isFutureEvent } = useMemo(() => {
+// normal one
+const currentTimeSecs = Math.floor(Date.now() / timeMultiplier);
+


Ctrl+S 🙏🏻

close to end added alot of things including css and html waiting for cr

62c995a

karnishein reviewed Dec 7, 2025

View reviewed changes

YoniKiriaty changed the title ~~close to end added alot of things including css and html waiting for cr~~ Playoff Schedule Dec 9, 2025

yoni check i am done

aeb81a9

YoniKiriaty requested changes Dec 9, 2025

View reviewed changes

YoniKiriaty added the project-init A PR to start off a project label Dec 10, 2025

looks good needs polish

d5c385b


		app.use(express.static(distDirectory));

		app.get(/^(.*)$/, (req, res) => {

	const apiKey = "YOUR_API_KEY";
	const apiKey = process.env.TBA_API_KEY ?? "YOUR_API_KEY";

		const map: Map<string, string> = new Map();
		teams.forEach(team => map.set(team.key, team.nickname));

Playoff Schedule #3

Are you sure you want to change the base?

Playoff Schedule #3

Uh oh!

Conversation

yoavs8 commented Dec 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YoniKiriaty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YoniKiriaty Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YoniKiriaty Dec 9, 2025 •

edited

Loading