Feat: Add Depth Control to Octree Visualization #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the Octree visualization system by adding depth-based drawing controls. This allows developers to inspect the Octree's structure level by level directly in the Unity editor. - **`OctreeBase.cs`**: The `DrawAllBounds()` and `DrawAllObjects()` methods have been updated to accept an optional `maxDepth` parameter. The recursive drawing logic in the `OctreeNode` now respects this limit. - **`OctreeVisualizer.cs`**: The base visualizer component now has a `public int maxDrawingDepth` field, which can be set in the Inspector to control the visualization depth. A value of -1 draws all levels. - **Specialized Visualizers**: The concrete visualizer components (`PointOctreeVisualizer`, `BoundsOctreeVisualizer`, `MeshOctreeVisualizer`) have been updated to pass the `maxDrawingDepth` value to the Octree's draw methods.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback on specific files or sections of files. For any comments you don't want me to act on, just include PS: Responding to comments on the entire PR are not yet supported but coming soon. For security, I will only act on instructions from the user who triggered this task for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to the Octree visualization system: depth-limited drawing. This is a powerful debugging tool that allows developers to inspect the Octree's structure and contents level by level.
Key Changes
Depth Parameter in Draw Methods: The
DrawAllBounds()andDrawAllObjects()methods inOctreeBasenow accept an optionalmaxDepthparameter. The internal drawing logic will not recurse past this depth, allowing for fine-grained control over the visualization.Inspector Control: A
maxDrawingDepthinteger field has been added to the baseOctreeVisualizercomponent. This allows the drawing depth to be set directly from the Unity Inspector. A value of -1 is used to signify no depth limit, which will draw the entire tree.Updated Visualizers: All specialized visualizer components have been updated to use this new functionality, passing the depth value from the Inspector to the Octree's drawing methods.