BUG fixing. #1
Open
BUG fixing. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application crashes without added string. If you have chosen some element(dot on view) and after that you drag your finger out of view, app crashes.
Added string cleans selected dots. If they will not be deselected, user starts to choose new pins, and programmer gets new selected dots' values, but visually old dots are selected, but they shouldn't be.
If user has chosen some dot(-s) and his touch has ended not on some other dot, selecting line remains. This line (startingPoint: last selected dot, endingPoint: where touch ends) must be cleared. This code change does it.
Additions for commit a5d6300 in DrawPatternLockViewController
Additions for commit a5d6300 in DrawPatternLockViewController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three bugs fixed: