Use clients IPs:port directly instead of proxy on studio

[kostyanf14]

@YanVugenfirer Please review but don't merge

[gemini-code-assist]

Summary of Changes

Hello @kostyanf14, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the connection mechanism within the RToolsHCK class, shifting from a centralized proxy model to a direct client-to-client connection approach. The changes involve updating configuration parameters, default values, and connection logic to enable more granular control over client WinRM connections and improve robustness by anticipating direct connection issues.

Highlights

• Direct Client Connections: The system now connects directly to client machines using their specific IP addresses and WinRM ports, moving away from a proxy-based approach through the studio machine.
• Configuration Updates: New constants for default WinRM and Ether ports have been introduced. The initialization options for RToolsHCK have been updated to include explicit port and ether_port settings, and the :winrm_ports option has been deprecated in favor of a more detailed :clients_addrs hash that specifies both IP and port for each client.
• Default IP Address Changes: The default IP address for the controller/studio machine has been updated from 127.0.0.1 to 192.168.100.1, and default client IP addresses are now explicitly defined.
• Error Handling: Error handling has been enhanced to specifically catch Errno::ECONNREFUSED exceptions during action execution, acknowledging that direct client connections might lead to such errors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This pull request refactors the RToolsHCK library to connect directly to client machines using their IP addresses and ports instead of routing through a proxy on the studio machine. This change aligns the configuration with the HLK-Setup-Script defaults and simplifies the network architecture.

Key Changes:

• Replaced the :winrm_ports parameter with :clients_addrs to support direct IP:port connections to clients
• Added new constants WINRM_DEFAULT_PORT (5985) and ETHER_DEFAULT_PORT (4000) for better configuration management
• Updated default IP addresses to match HLK-Setup-Script settings (192.168.100.x range)
• Added Errno::ECONNREFUSED exception handling for connection retry scenarios

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

The pull request updates the RToolsHCK class to directly use client IP addresses and ports for connections, moving away from a proxy-based approach. This involves introducing new constants for default ports, updating initialization options and their documentation, and modifying connection logic to reflect these changes. A deprecation warning for the old :winrm_ports option has also been added. The changes are generally well-implemented, improving configurability and clarity regarding connection parameters.