Skip to content

Conversation

@miikkas
Copy link
Contributor

@miikkas miikkas commented Jun 6, 2025

I noticed that in projects depending separately on both RealFFT and RustFFT, the default features of RustFFT get selected even when configuring that dependency with default-features = false and features = ["avx"].

This PR adds the features available in RustFFT to RealFFT as well, enabling the corresponding RustFFT features only when selected. RealFFT's default feature enables RustFFT's default feature, so existing use cases shouldn't be affected.

@HEnquist
Copy link
Owner

HEnquist commented Jun 7, 2025

Thanks for the PR! This is a nice improvement, I'll include it in the next release. I expect a new release of RustFFT very soon (see ejmahler/RustFFT#157), I'll just wait for that before making a new release here.

One little point of feedback. I think the readme could mention that the features are only passed on to RustFFT and don't affect RealFFT itself at all.

@miikkas miikkas force-pushed the map-to-rustfft-features branch from 7769ce5 to e5aba75 Compare June 8, 2025 09:34
@miikkas
Copy link
Contributor Author

miikkas commented Jun 8, 2025

That's a good point. I have modified the added documentation bit according to your feedback now.

@HEnquist
Copy link
Owner

HEnquist commented Jun 8, 2025

Thanks, looks good! I'll merge this when it's time to create the next release. I prefer to keep the master branch identical to the latest release on crates.io to avoid some confusion.

@ejmahler
Copy link

Rustfft update published: https://crates.io/crates/rustfft/6.4.0

@HEnquist HEnquist merged commit 0084ee2 into HEnquist:master Jun 12, 2025
4 of 5 checks passed
@HEnquist
Copy link
Owner

RealFFT updated too :)
https://crates.io/crates/realfft/3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants