Hbl next v2 #9
Open
Hbl next v2 #9
+107
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmeriin
requested changes
Jan 27, 2025
| int hbl_cn_alloc_ring(struct hbl_cn_device *hdev, struct hbl_cn_ring *ring, int elem_size, | ||
| int count); | ||
| void hbl_cn_free_ring(struct hbl_cn_device *hdev, struct hbl_cn_ring *ring); | ||
| void hlb_cn_cfg_lock(struct hbl_cn_port *cn_port); |
Contributor
There was a problem hiding this comment.
please change all function names to hbl not hlb
For upstream purposes and to have more robust code, a common cfg lock function shall be created. The function shall invoke the asic port's specific function. Signed-off-by: Tal Cohen <tal5.cohen@intel.com>
Replace the port's cfg lock from port specific into port's common code. This change is further to the common cfg lock function change. Signed-off-by: Tal Cohen <tal5.cohen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.