Skip to content

Enable adding label without icon #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danleedham merged 6 commits into from
Dec 17, 2025
Merged

Enable adding label without icon #7

danleedham merged 6 commits into from
Dec 17, 2025

Conversation

@danleedham
Copy link
Contributor

@danleedham danleedham commented Dec 17, 2025 •
edited
Loading

Breaking change: build() now throws, to ensure if KMZ is required this is flagged.

  • Adds support for KMZ generation
  • Requires KMZ if custom icon is used
  • Adds Label Only element which has no visible icon
  • Updates Demo App to use KMZ

@danleedham danleedham added this to the 0.4.0 milestone Dec 17, 2025
@danleedham danleedham requested a review from Mirrafoil December 17, 2025 15:40
Mirrafoil
Mirrafoil reviewed Dec 17, 2025
View reviewed changes
README.md
Copy link

@Mirrafoil Mirrafoil Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a pendantic point ref geometry naming. I think the thing we're calling a 'segment' should be called 'sector'.

@danleedham danleedham merged commit 1581ae7 into develop Dec 17, 2025
1 check passed
@danleedham danleedham deleted the LabelOnly branch December 17, 2025 20:32
@danleedham danleedham mentioned this pull request Dec 17, 2025
Merged
danleedham added a commit that referenced this pull request Dec 18, 2025
@danleedham
Version 0.4.0 (#9)
8a8fb77 
* Update example app to use remote dependency
* Embed image in repo (#2)
* Add function for annular sectors (#4)
* Add Swiftlint
* Enable adding label without icon (#7)
* Enable export by KMZ (#7) 
* Update readme
* Use Sector and Segment correctly (#8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mirrafoil Mirrafoil Mirrafoil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@danleedham @Mirrafoil