Catapp feedback #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this branch!
Homework Feedback for Cat App
The link you sent in the homework survey did not exist anymore, so I went back in your commit history to find your original cat app. In the commit I am looking at there are a lot of old/extra files you would want to remove, but I'm assuming you did this later after this commit. (Your "move cat app" commit appeared to removed the cat app instead of moving it.)
Functionality:
All tasks completed!* Awesome job, and your app appears to be bug free. :D
*Second submission
Completion: (20/20)
Bug Free: (10/10)
Quality:
Your code was well organized and commented! It was very clear and readable.
Citing references when you took code from online was great. A good next step would be adding comments describing your functions for the functions you did not do this for.
Good Coding Practices: (10/10)
Readability: (9/10)
Summary: Nice work! Everything is functional and you followed good practices.
(49/50)