Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lessons/04-client-jquery-ajax/burgerApp/app.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Some comments would be nice here for style/readability.
// What you have here is pretty straightforward, but it's a good habit to get into.
var express = require('express');
var path = require('path');
var logger = require('morgan');
Expand Down
20 changes: 20 additions & 0 deletions lessons/04-client-jquery-ajax/burgerApp/feedback.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
Burger App Homework Feedback

Everything seems to be working! Love the favicon.
Awesome website. Terrible burgers.

Functionality
All pages had full functionality and it doesn't look like there are any bugs!

Completion: 20/20
Bug Free: 10/10

Quality
Your styling is consistent throughout and you generally follow good practices!
You forgot to delete the index.js from the boilerplate/in-class exercise, and left some unnecessary logs.
Unfortunately the lack of comments hurt readability. Other than that, nice work!

Good coding practices: 9/10
Readability: 6/10

Total: 45/50
2 changes: 2 additions & 0 deletions lessons/04-client-jquery-ajax/burgerApp/models/burgerModel.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
var mongoose = require('mongoose');

// Create ingredient Schema
// Create burger schema
// Try to make sure you update your comments after making changes!
var burgerSchema = mongoose.Schema({
orderNumber: Number,
ingredients: [String]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// There are no comments here.
// While your code is pretty readable,
// commenting is super important so that other people
// (and future you) can understand it better.

var $form = $("#ajax-form");

var totalCost = 0;
Expand Down
2 changes: 2 additions & 0 deletions lessons/04-client-jquery-ajax/burgerApp/routes/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Delete files you are no longer using.

var home = function(req, res){
res.render("home", {"classes": [
"Olin.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ routes.editPOST = function(req, res) {
if(err) {
console.error("error updating name/price:", err);
}
console.log(newDoc);
console.log(newDoc); // Probably don't need this console.log. It's usually good to get rid of these when you are done.
res.send(newDoc);
});
});
Expand Down