Skip to content

Conversation

@billmwong
Copy link
Collaborator

@billmwong billmwong commented Apr 18, 2017

Homework Rubric: 47/50 total

Nice job Taylor! Review your comments here and then close this PR when you're done.

Functionality: 29/30

Completion: 20/20

  • 20 - You implemented all of the required features in the assignment. The assignment is complete
  • 15 - All major features were implemented. You didn't get to one or two small features.
  • 10 - Some of the required features were implemented.
  • 5 - An attempt was made to implement some of the of the desired features.
  • 0 - Very few or none of the desired features were implemented.

Bug free: 9/10

  • 10 - The app is bug free
  • 5 - Your app has one or two bugs, occasionally causing unexpected behavior
    Not really a bug, but you have an interesting functionality where in order to edit, the user has to double-click on an item. But single-clicking on an item toggles its completeness, so it toggles and then I assume toggles back after your second click.

Quality: 18/20

See my in-line comments in your code.

Good coding practices: 9/10

  • 10 - Follow good naming conventions, use triple equals, use indents and whitespace where appropriate, know when to use global or local variables, etc.
  • 5 - Some of the above practices were broken, but you mostly followed good practices.
  • 0 - Good coding practices were consistently broken.

Readability: 9/10

  • 10 - Functions and variables are named well. Code is well commented where appropriate. Confusing lines are commented. Lines are not too long.
  • 5 - Code is occasionally confusing. Could use more comments. Some variables are poorly named.

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants