Skip to content

Report battery level on peripheral side #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HaoboGu merged 34 commits into from
Jan 3, 2026
Merged

Report battery level on peripheral side #633

HaoboGu merged 34 commits into from
Jan 3, 2026

Conversation

@HaoboGu
Copy link
Owner

@HaoboGu HaoboGu commented Nov 21, 2025

No description provided.

@HaoboGu
feat(split): add battery level to split message
8c867c1 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
feat(split): receive battery level from peripheral
387d306 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

Binary Size Report

use_config/nrf52832_ble

   text	   data	    bss	    dec	    hex	filename
 313360	   5072	  32476	 350908	  55abc	rmk-nrf52832
Diff 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +502  [ = ]       0    .debug_str
  +0.0%    +414  [ = ]       0    .debug_info
  +0.0%     +24  [ = ]       0    .debug_ranges
  +0.0%     +17  [ = ]       0    .debug_line
  +0.0%      +6  [ = ]       0    .debug_loc
  +0.0%      +1  [ = ]       0    .strtab
  -7.8%      -4  [ = ]       0    [Unmapped]
  +0.0%    +960  [ = ]       0    TOTAL

use_config/nrf52840_ble

   text	   data	    bss	    dec	    hex	filename
 351164	   5072	  48276	 404512	  62c20	rmk-nrf52840
Diff 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +529  [ = ]       0    .debug_info
  +0.0%    +260  [ = ]       0    .debug_str
  +0.0%     +38  [ = ]       0    .strtab
  +0.0%     +24  [ = ]       0    .debug_ranges
   +52%     +24  [ = ]       0    [Unmapped]
  +0.0%      +8  +0.0%      +8    .text
  +0.0%      +6  [ = ]       0    .debug_loc
  -0.0%      -5  [ = ]       0    .debug_line
  +0.0%    +884  +0.0%      +8    TOTAL

use_config/nrf52840_ble_split

   text	   data	    bss	    dec	    hex	filename
 426128	   6376	  44308	 476812	  7468c	central

   text	   data	    bss	    dec	    hex	filename
 273828	   5740	  28252	 307820	  4b26c	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.3% +41.0Ki  [ = ]       0    .debug_str
  +1.4% +27.2Ki  [ = ]       0    .debug_info
  +1.0% +5.73Ki  [ = ]       0    .debug_loc
  +1.7% +3.49Ki  [ = ]       0    .debug_ranges
  +0.8% +2.68Ki  [ = ]       0    .debug_line
  +0.6% +2.11Ki  +0.6% +2.11Ki    .text
  +0.5% +1.56Ki  [ = ]       0    .strtab
  +0.4%    +576  [ = ]       0    .symtab
  +0.9%    +416  +0.9%    +416    .rodata
  +0.5%    +228  [ = ]       0    .debug_frame
  [ = ]       0  +0.4%    +184    .bss
  +0.2%     +88  [ = ]       0    .debug_aranges
  +0.2%     +16  [ = ]       0    .debug_abbrev
   +40%     +16  [ = ]       0    [Unmapped]
  +1.0%      +8  [ = ]       0    .defmt
  +1.2% +85.1Ki  +0.6% +2.70Ki    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +2.7% +52.7Ki  [ = ]       0    .debug_str
  +2.3% +29.6Ki  [ = ]       0    .debug_info
  +1.1% +4.11Ki  [ = ]       0    .debug_loc
  +1.7% +3.20Ki  [ = ]       0    .strtab
  +1.5% +3.12Ki  [ = ]       0    .debug_line
  [ = ]       0  +9.4% +2.29Ki    .bss
  +0.5% +1.17Ki  +0.5% +1.17Ki    .text
  +2.3%    +736  +2.3%    +736    .rodata
  +0.4%    +584  [ = ]       0    .debug_ranges
  +0.8%    +224  [ = ]       0    .debug_frame
  +0.2%    +144  [ = ]       0    .symtab
  +1.7%    +126  [ = ]       0    .debug_abbrev
   +40%     +19  [ = ]       0    [Unmapped]
  +1.5%      +8  [ = ]       0    .defmt
  -0.1%     -48  [ = ]       0    .debug_aranges
  +2.1% +95.6Ki  +1.4% +4.18Ki    TOTAL

use_rust/nrf52840_ble_split

   text	   data	    bss	    dec	    hex	filename
 428996	   6376	  50668	 486040	  76a98	central

   text	   data	    bss	    dec	    hex	filename
 272856	   5196	  26988	 305040	  4a790	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2% +5.86Ki  [ = ]       0    .debug_str
  +0.1% +2.60Ki  [ = ]       0    .debug_info
  +0.1%    +419  [ = ]       0    .strtab
  +0.2%    +352  [ = ]       0    .debug_ranges
  +0.1%    +227  [ = ]       0    .debug_line
  +0.0%    +184  +0.0%    +184    .text
  +0.0%     +64  [ = ]       0    .symtab
  [ = ]       0  +0.1%     +56    .bss
  +0.1%     +32  [ = ]       0    .debug_aranges
  +0.1%     +32  +0.1%     +32    .rodata
  +0.0%     +29  [ = ]       0    .debug_loc
   +20%     +12  [ = ]       0    [Unmapped]
  +0.5%      +4  [ = ]       0    .defmt
  +0.1% +9.78Ki  +0.1%    +272    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +2.4% +46.2Ki  [ = ]       0    .debug_str
  +2.2% +28.3Ki  [ = ]       0    .debug_info
  +1.7% +6.82Ki  [ = ]       0    .debug_loc
  +1.9% +4.00Ki  [ = ]       0    .debug_line
  +1.8% +3.43Ki  [ = ]       0    .strtab
  [ = ]       0  +9.9% +2.28Ki    .bss
  +1.5% +1.90Ki  [ = ]       0    .debug_ranges
  +0.7% +1.67Ki  +0.7% +1.67Ki    .text
  +2.5%    +824  +2.5%    +824    .rodata
  +0.5%    +448  [ = ]       0    .symtab
  +1.0%    +280  [ = ]       0    .debug_frame
  +1.2%     +92  [ = ]       0    .debug_abbrev
  +0.0%     +16  [ = ]       0    .debug_aranges
  +2.3%     +12  [ = ]       0    .defmt
 -11.8%      -6  [ = ]       0    [Unmapped]
  +2.0% +94.0Ki  +1.6% +4.76Ki    TOTAL

use_config/pi_pico_w_ble

   text	   data	    bss	    dec	    hex	filename
 587008	      0	  53908	 640916	  9c794	rmk-pi-pico-w
Diff 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +492  [ = ]       0    .debug_str
  +0.0%    +377  [ = ]       0    .debug_info
  +0.0%    +142  [ = ]       0    .debug_loc
  -0.0%      -3  [ = ]       0    .strtab
  +0.0%   +1008  [ = ]       0    TOTAL

use_config/pi_pico_w_ble_split

   text	   data	    bss	    dec	    hex	filename
 619648	      0	  60660	 680308	  a6174	central

   text	   data	    bss	    dec	    hex	filename
 488364	      0	  41984	 530348	  817ac	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%   +1024  [ = ]       0    .debug_info
  +0.0%    +922  [ = ]       0    .debug_str
  +0.0%    +339  [ = ]       0    .debug_loc
  +0.0%    +148  +0.0%    +148    .text
  +0.0%     +93  [ = ]       0    .debug_line
  +0.0%     +65  [ = ]       0    .strtab
  +0.0%     +16  [ = ]       0    .debug_aranges
  +0.0%     +16  [ = ]       0    .debug_ranges
 -32.9%     -23  [ = ]       0    [Unmapped]
  +0.0% +2.54Ki  +0.0%    +148    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.1% +24.1Ki  [ = ]       0    .debug_str
  +0.8% +11.8Ki  [ = ]       0    .debug_info
  +1.2% +7.04Ki  [ = ]       0    .debug_loc
  +1.0% +2.60Ki  [ = ]       0    .debug_line
  +1.3% +1.83Ki  [ = ]       0    .debug_ranges
  +0.8% +1.43Ki  [ = ]       0    .strtab
  +0.7% +1.34Ki  +0.7% +1.34Ki    .text
  +1.0%    +496  [ = ]       0    .symtab
  +0.1%    +240  +0.1%    +240    .rodata
  +0.7%    +184  [ = ]       0    .debug_frame
  +0.2%     +64  [ = ]       0    .debug_aranges
  [ = ]       0  +0.1%     +32    .bss
  +0.2%     +18  [ = ]       0    .debug_abbrev
  +0.6%      +3  [ = ]       0    .defmt
 -15.9%      -7  [ = ]       0    [Unmapped]
  +0.9% +51.2Ki  +0.3% +1.61Ki    TOTAL

use_rust/pi_pico_w_ble_split

   text	   data	    bss	    dec	    hex	filename
 619872	      0	  60972	 680844	  a638c	central

   text	   data	    bss	    dec	    hex	filename
 488608	      0	  41984	 530592	  818a0	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +1.04Ki  [ = ]       0    .debug_info
  +0.0%    +922  [ = ]       0    .debug_str
  +0.0%    +136  +0.0%    +136    .text
  +0.0%     +73  [ = ]       0    .debug_line
  +0.0%     +65  [ = ]       0    .strtab
  +0.0%     +16  [ = ]       0    .debug_aranges
 -15.8%      -9  [ = ]       0    [Unmapped]
  -0.0%     -80  [ = ]       0    .debug_ranges
  -0.0%    -147  [ = ]       0    .debug_loc
  +0.0% +2.00Ki  +0.0%    +136    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.1% +24.1Ki  [ = ]       0    .debug_str
  +0.8% +11.9Ki  [ = ]       0    .debug_info
  +1.0% +5.54Ki  [ = ]       0    .debug_loc
  +0.9% +2.27Ki  [ = ]       0    .debug_line
  +1.1% +1.64Ki  [ = ]       0    .debug_ranges
  +0.8% +1.39Ki  [ = ]       0    .strtab
  +0.7% +1.37Ki  +0.7% +1.37Ki    .text
  +0.5%    +272  [ = ]       0    .symtab
  +0.1%    +240  +0.1%    +240    .rodata
  +0.7%    +184  [ = ]       0    .debug_frame
  +0.2%     +64  [ = ]       0    .debug_aranges
  [ = ]       0  +0.1%     +32    .bss
  +0.6%      +3  [ = ]       0    .defmt
 -18.3%     -11  [ = ]       0    [Unmapped]
  +0.9% +49.0Ki  +0.3% +1.64Ki    TOTAL

use_config/rp2040

   text	   data	    bss	    dec	    hex	filename
 131412	      0	  15444	 146856	  23da8	rmk-rp2040
Diff 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -1.6%      -1  [ = ]       0    [Unmapped]
  -0.0%      -4  [ = ]       0    .strtab
  -0.0%     -11  [ = ]       0    .debug_str
  -0.0%     -16  [ = ]       0    TOTAL

use_config/rp2040_split

   text	   data	    bss	    dec	    hex	filename
 145340	      0	  17016	 162356	  27a34	central

   text	   data	    bss	    dec	    hex	filename
  26536	      0	   2944	  29480	   7328	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +541  [ = ]       0    .debug_info
  +0.0%    +437  [ = ]       0    .debug_str
  +0.1%    +148  +0.1%    +148    .text
  +0.1%    +116  [ = ]       0    .debug_line
  +0.0%     +41  [ = ]       0    .strtab
  +0.1%     +16  [ = ]       0    .debug_aranges
  +0.0%     +16  [ = ]       0    .debug_ranges
   +36%     +15  [ = ]       0    [Unmapped]
  -0.2%    -642  [ = ]       0    .debug_loc
  +0.0%    +688  +0.1%    +148    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +3.1% +17.1Ki  [ = ]       0    .debug_str
  +3.5% +11.1Ki  [ = ]       0    .debug_info
   +13% +6.36Ki  [ = ]       0    .debug_loc
  +4.7% +2.66Ki  [ = ]       0    .debug_line
   +11% +1.48Ki  [ = ]       0    .debug_ranges
  +7.7% +1.48Ki  +7.7% +1.48Ki    .text
  +3.4%    +874  [ = ]       0    .strtab
  +3.0%    +272  [ = ]       0    .symtab
  +5.3%    +244  +5.4%    +244    .rodata
  +3.6%    +206  [ = ]       0    .debug_abbrev
  +2.7%    +144  [ = ]       0    .debug_frame
  +0.6%     +72  [ = ]       0    .debug_aranges
  [ = ]       0  +1.3%     +24    .bss
   +22%      +8  [ = ]       0    [Unmapped]
  +2.1%      +3  [ = ]       0    .defmt
  +3.9% +42.0Ki  +6.4% +1.74Ki    TOTAL

use_rust/rp2040_split

   text	   data	    bss	    dec	    hex	filename
 144632	      0	  16612	 161244	  275dc	central

   text	   data	    bss	    dec	    hex	filename
  27144	      0	   3184	  30328	   7678	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%    +596  [ = ]       0    .debug_loc
  +0.1%    +550  [ = ]       0    .debug_info
  +0.0%    +437  [ = ]       0    .debug_str
  +0.1%    +116  +0.1%    +116    .text
  +0.1%     +94  [ = ]       0    .debug_line
  +0.2%     +64  [ = ]       0    .symtab
  +0.0%     +53  [ = ]       0    .strtab
  +0.1%     +16  [ = ]       0    .debug_aranges
  +0.0%     +16  [ = ]       0    .debug_ranges
   +21%     +10  [ = ]       0    [Unmapped]
  +0.1% +1.91Ki  +0.1%    +116    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +3.1% +17.1Ki  [ = ]       0    .debug_str
  +3.4% +10.9Ki  [ = ]       0    .debug_info
   +16% +7.29Ki  [ = ]       0    .debug_loc
  +4.7% +2.68Ki  [ = ]       0    .debug_line
   +12% +1.55Ki  [ = ]       0    .debug_ranges
  +7.5% +1.46Ki  +7.5% +1.46Ki    .text
  +3.2%    +817  [ = ]       0    .strtab
  +2.4%    +224  [ = ]       0    .symtab
  +3.6%    +206  [ = ]       0    .debug_abbrev
  +4.2%    +204  +4.2%    +204    .rodata
  +2.2%    +116  [ = ]       0    .debug_frame
  +0.5%     +64  [ = ]       0    .debug_aranges
  [ = ]       0  +1.1%     +24    .bss
  +2.1%      +3  [ = ]       0    .defmt
 -13.3%      -6  [ = ]       0    [Unmapped]
  +3.9% +42.5Ki  +6.0% +1.68Ki    TOTAL

use_config/stm32f1

   text	   data	    bss	    dec	    hex	filename
  51704	     24	   7616	  59344	   e7d0	rmk-stm32f1
Diff 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

use_config/stm32f4

   text	   data	    bss	    dec	    hex	filename
 135780	    320	  16880	 152980	  25594	rmk-stm32f4
Diff 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +239  [ = ]       0    .debug_info
  +0.0%     +52  [ = ]       0    .debug_str
  +0.0%     +32  [ = ]       0    .strtab
  +0.0%      +8  +0.0%      +8    .text
 -19.6%     -10  [ = ]       0    [Unmapped]
  -0.0%     -12  [ = ]       0    .debug_line
  -0.0%     -29  [ = ]       0    .debug_loc
  +0.0%    +280  +0.0%      +8    TOTAL

use_config/stm32h7

   text	   data	    bss	    dec	    hex	filename
  95420	    264	  11000	 106684	  1a0bc	rmk-stm32h7
Diff 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +94  [ = ]       0    .debug_info
  +0.0%     +23  [ = ]       0    .debug_str
  +7.3%      +3  [ = ]       0    [Unmapped]
  +0.0%    +120  [ = ]       0    TOTAL

@HaoboGu HaoboGu marked this pull request as ready for review November 28, 2025 03:28
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2025 •
edited
Loading

Deploying rmk-rs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a8eb63
Status: ✅  Deploy successful!
Preview URL: https://ff687fb6.rmk-4a2.pages.dev
Branch Preview URL: https://feat-peripheral-bat.rmk-4a2.pages.dev

View logs

HaoboGu and others added 21 commits December 3, 2025 15:33
@HaoboGu
refactor: fix clippy warning
3e1d7af 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Merge branch 'main' into feat/peripheral_bat
a24f6fe 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor: fmt code
8c5a302 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
feat(split, config): support setting adc in [split.central] section
e49a653 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor: add conflict config verification
89f5e05 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
fix: fix peripheral bat config
837c2c6 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
doc: add Urchin keyboard to examples
9733a71
@decaday @HaoboGu
chore: update and lock RMK version for py32/sf32 example
82af47d
@decaday @HaoboGu
ci: add py32/sf32 examples to workflow
2887eba
@kot149 @HaoboGu
feat: add report_hz option to Pmw3610Device
5c1e770
@kot149 @HaoboGu
refactor: Optimize the timing for motion read and sending reports on …
a9b391b 
…the PMW3610
@HaoboGu
refactor: improve keycode implementation
71e0b88 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
feat(debouncer): reimplement default debouncer, refine DebouncerTrait
b0272a7 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
fix: fix wrong config name for configuring 2m phy
c7c34c1 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor(types): rewrite internal KeyCode
a32e508 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
test: fix all tests for new KeyCode
829390e 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
fix: fix legacy macro representation in keyboard.toml
e1ae4bd 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor: remove unused file
82fb41b 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
fix: fix example build error
801b87c 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
test: fix test imports
3fd113b 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor(types): use FromRepr for HidKeyCode
2b19b11 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
HaoboGu added 7 commits January 3, 2026 15:11
@HaoboGu
refactor: fix fmt and clippy
592e5e2 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor: adjust Action names and structure
38e7c90 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
fix: fix delayed combo trigger when combos are overlapped
b096f1a 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor: make field in KeyboardEvent pub
35a6628 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Merge branch 'main' into feat/peripheral_bat
9a8eb63
@HaoboGu
feat: add bettery level monitoring to use_rust peripheral example
222a7e9 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
refactor: fmt code
46286ef 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu merged commit 13d227d into main Jan 3, 2026
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HaoboGu @decaday @kot149