Fix constant DAT file reading. #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of `block_native.lua` causes DAT file read thrashing. Due to this, the status icon DAT file is constantly being read multiple times per-frame (based on the number of buffs on the player/target party member) which can lead to lag or decreased SSD lifespans. This commit fixes that issue by allowing the client to handle the DAT file properly, while also fully disabling the rendering of both the local client's status icons and their target party members icons. This commit also now prevents the keyboard highlighting of the original in-game status icon bar entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
block_native.luacauses DAT file read thrashing. Due to this, the status icon DAT file is constantly being read multiple times per-frame (based on the number of buffs on the player/target party member) which can lead to lag or decreased SSD lifespans.This commit fixes that issue by allowing the client to handle the DAT file properly, while also fully disabling the rendering of both the local client's status icons and their target party members icons.
This commit also now prevents the keyboard highlighting of the original in-game status icon bar entirely.