-
Notifications
You must be signed in to change notification settings - Fork 2
Allows for multiple computers to connect at the same time. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fixed by having the frontend call the server's backend
|
@noam987 I fixed your merge conflicts for you after merging the fixes @DitrusNight made to the front-end in #3 (which rendered some of my previous comments irrelevant). If you want to give this a test and see if your changes still work for multiple computer use, make whatever changes you need to make, approve this PR and then feel free to merge it. |
|
It appears that there are two errors with the current status of the bug-fixing branch that you would like to address before merging. Secondly, https://github.com/HelloWorldHackathon/My-CS-Plan/pull/2/files#diff-999051457a1934c824a5f8395589ea5e749a581e9f70a43585c885319cb56e64R10545-R10559 (package-lock.json, line 10545-10559) |
|
I'm going to do a full cleanup and look at this tomorrow. |
|
The deep-copy change I was aware of and the line is still there, just admittedly useless - I added a comment for Noam to take a look as you're totally right on the deep_copy not being used at all. Noam's code is still viewable in the commit history for this PR so hopefully, it shouldn't be too difficult to create a "best mix." Regarding the merge conflict, excellent catch, I completely missed that conflict and you're right that we'd want both! GitHub can be a total pain but hey this is why we don't commit directly to the main right? |

Done by @noam987: Fixed by having the frontend call the server's backend