Skip to content

Conversation

@tdaron
Copy link
Contributor

@tdaron tdaron commented Dec 17, 2023

I created this feature because it can be quite convenient to download an entire moodle in one-time.

Currently supported: Chrome + Firefox

Current issues:

Due to a firefox bug , the lib client-zip i am using to generate the zip on chrome is not working on firefox. so for now, firefox has to download file one by one (still automatically)

FIXED using zip.js

Possible improvements:

Improve UI, currently using only window.confirm as a UI but it's not really user-friendly. And there is not any progress information except console.

Organizing files in zip by folder

@tdaron
Copy link
Contributor Author

tdaron commented Dec 17, 2023

Recording 2023-12-17 at 21 24 19

@tdaron
Copy link
Contributor Author

tdaron commented Dec 18, 2023

I just fixed firefox zip issue using zip.js lib, but i don't like my solutions, mainly because zip.js does not work the way i wanted it to, forcing me to use HttpReader and make two fetch per files (firefox issue, maybe) and firefox's content-script x-ray features is shitty (i lost a lot of time)

(But it's not that bad because the browser caches data between requests so making two requests per file does not download two times the file)

@Hokkaydo
Copy link
Owner

Oh I like this feature!
Indeed it could be interesting to have a nice UI with a progress bar (for remaining files to select for example)

@tdaron
Copy link
Contributor Author

tdaron commented Dec 21, 2023

Recording 2023-12-21 at 11 20 07

@tdaron
Copy link
Contributor Author

tdaron commented Dec 21, 2023

Your thoughts on this menu @Hokkaydo ? (basic styling, can be more beautiful)

runKeepAlive();
} else {
console.log("clear")
clearInterval(keepAliveIntervalId);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a format of the file, here is why things here changed

@Hokkaydo
Copy link
Owner

Your thoughts on this menu @Hokkaydo ? (basic styling, can be more beautiful)

I like the window's style, maybe add some padding at the bottom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants