Skip to content

Conversation

@streamside
Copy link

An error is thrown if using a delay to open the drop but the the drop has been destroyed at the point in time when it us supposed to be opened/closed.

Example: The user hovers an icon, a setTimeout(open, 300) is created, something else happens which destroys the drop (calling destroy()), the 300 ms has passed and the drop now tries to open but it no longer exist and an error is displayed.

@wjt
Copy link

wjt commented Apr 5, 2016

(I'm not a Drop developer, just a user who is seeing the same bug.)

This fix works for me: ace! Here's a minimal-ish test case which raises an exception without this fix and not with. Judging by other PRs and CONTRIBUTING.md you'll be asked to commit the result of running npm run build (so your changes are in dist/) and gulp version:patch to bump the patch version number.

@fromthemills
Copy link

Can we get this moving? Having trouble with same bug.

@ghost
Copy link

ghost commented Sep 26, 2016

Bump, having a similar issue that this pull request would fix.

@Akryum
Copy link

Akryum commented Nov 15, 2016

Same here, waiting for this to be merged!

@zmdavis
Copy link

zmdavis commented Feb 15, 2017

@streamside Any interest in bringing this up to date with the latest version?

Also, it would be nice to get some feedback from the maintainers on what's preventing this from being merged. As I mentioned in #169 a low-impact (but less precise) alternative would be to return early from the open (or close) function if this.drop is null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants