Skip to content

ci: demo Checkstyle in static analysis #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
baptistegrimaud wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: demo Checkstyle in static analysis #478

baptistegrimaud wants to merge 1 commit into from

Conversation

@baptistegrimaud
Copy link
Contributor

@baptistegrimaud baptistegrimaud commented Sep 4, 2025

Description

...

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

@baptistegrimaud baptistegrimaud force-pushed the guild-day-linting-checkstyles branch from 0d0f87c to 63070bc Compare September 4, 2025 19:59
jahia-ci
jahia-ci reviewed Sep 4, 2025
View reviewed changes
...java/org/jahia/modules/javascript/modules/engine/jshandler/JavascriptProtocolConnection.java
}
// Map everything else in settings/ to META-INF/
else {
else
Copy link
Contributor

@jahia-ci jahia-ci Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'else' construct must use '{}'s.

@baptistegrimaud baptistegrimaud force-pushed the guild-day-linting-checkstyles branch from 1b8652c to 32ea546 Compare September 5, 2025 09:45
jahia-ci
jahia-ci reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@jahia-ci jahia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 80 in 32ea546

for (Bundle bundle : getJavascriptModules()) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 81 in 32ea546

engine.disableJavascriptModule(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 82 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 83 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 85 in 32ea546

@Override

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 86 in 32ea546

public void bundleChanged(BundleEvent event) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 87 in 32ea546

try {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 88 in 32ea546

Bundle bundle = event.getBundle();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 89 in 32ea546

if (isJavascriptModule(bundle)) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 90 in 32ea546

if (event.getType() == BundleEvent.STARTED) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 91 in 32ea546

engine.enableJavascriptModule(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 92 in 32ea546

for (Registrar registrar : registrars) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 93 in 32ea546

registrar.register(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 94 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 95 in 32ea546

} else if (event.getType() == BundleEvent.STOPPED) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 96 in 32ea546

for (Registrar registrar : registrars) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 97 in 32ea546

registrar.unregister(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 98 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 99 in 32ea546

engine.disableJavascriptModule(bundle);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 100 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 101 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 102 in 32ea546

} catch (Exception e) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 103 in 32ea546

logger.error("Cannot handle event {}", event.toString(), e);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 104 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 105 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 107 in 32ea546

public List<Bundle> getJavascriptModules() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 108 in 32ea546

return Arrays.stream(engine.getBundleContext().getBundles())

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 109 in 32ea546

.filter(bundle -> bundle.getState() == Bundle.ACTIVE && isJavascriptModule(bundle))

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 110 in 32ea546

.collect(Collectors.toList());

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 111 in 32ea546

}

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 113 in 32ea546

public boolean isJavascriptModule(Bundle bundle) {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 114 in 32ea546

return bundle.getBundleId() != engine.getBundleContext().getBundle().getBundleId() &&

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 115 in 32ea546

bundle.getHeaders().get(BUNDLE_HEADER_JAVASCRIPT_INIT_SCRIPT) != null;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

javascript-modules/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

Line 116 in 32ea546

}

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
return bundle.getBundleId() != engine.getBundleContext().getBundle().getBundleId() &&
bundle.getHeaders().get(BUNDLE_HEADER_JAVASCRIPT_INIT_SCRIPT) != null;
}
private static final Logger logger = LoggerFactory.getLogger(JavascriptModuleListener.class);
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
bundle.getHeaders().get(BUNDLE_HEADER_JAVASCRIPT_INIT_SCRIPT) != null;
}
private static final Logger logger = LoggerFactory.getLogger(JavascriptModuleListener.class);
private GraalVMEngine engine;
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
}
private static final Logger logger = LoggerFactory.getLogger(JavascriptModuleListener.class);
private GraalVMEngine engine;
private final Queue<Registrar> registrars = new ConcurrentLinkedQueue<>();
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
private GraalVMEngine engine;
private final Queue<Registrar> registrars = new ConcurrentLinkedQueue<>();

@Reference(cardinality = ReferenceCardinality.MANDATORY)
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
private final Queue<Registrar> registrars = new ConcurrentLinkedQueue<>();

@Reference(cardinality = ReferenceCardinality.MANDATORY)
public void setEngine(GraalVMEngine engine) {
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
engine.enableJavascriptModule(bundle);
}

context.addBundleListener(this);
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
}

context.addBundleListener(this);
}
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
context.addBundleListener(this);
}

@Deactivate
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java
}

@Deactivate
public void deactivate(BundleContext context) {
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

...java/src/main/java/org/jahia/modules/javascript/modules/engine/JavascriptModuleListener.java

@Deactivate
public void deactivate(BundleContext context) {
context.removeBundleListener(this);
Copy link
Contributor

@jahia-ci jahia-ci Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@baptistegrimaud baptistegrimaud changed the title ci: add Checkstyle ci: demo Checkstyle in static analysis Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jahia-ci jahia-ci jahia-ci left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baptistegrimaud @jahia-ci