This repository was archived by the owner on Oct 22, 2019. It is now read-only.
Prevent exception from being thrown on 200 #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…within the constructor
Upgrade Prometheus client to PHP 7 Approved-by: Andre Ferraz <andre.ferraz@endclothing.com> Approved-by: DuShaun Alderson-Claeys <dushaun.alderson-claeys@endclothing.com>
Bump to version 1.0.0 (API is the same, but requires php 7.1) Approved-by: Andre Ferraz <andre.ferraz@endclothing.com> Approved-by: DuShaun Alderson-Claeys <dushaun.alderson-claeys@endclothing.com> Approved-by: Robin Shimield <robin.shimield@endclothing.com>
^7.3 is required version of php
Run tests for PHP 7.3 and 7.4, no more support for < 7.3 (required in composer)
Update .travis.yml
Update README.md
Add original package (`jimdo/prometheus_client_php`) to the replace list
* WIP CI * Move few things around in CI pipeline * remove unneeded CI job
* allow status 202 in case of downwards compatibility * add allowance of status 200 for prometheus/pushgateway >=0.10.0 * fix grouping key, because of not matching declerations * simplify if to add more status code easier
Added CI using CircleCI
* Inject Redis via named constructor * change method name * Added withExistingConnection test * Fix for redis prefix support and respective tests * removed unneeded code * phpcbf
* Update phpunit to version 8 * fix shield * Require PHPUnit version at least 8.4
bvisness
force-pushed
the
master
branch
3 times, most recently
from
a02baed to
65662f5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pushgateway now returns 200s in most cases. 202 is only used for deletes.
Should fix #120.