Just a bit of cleanup #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
master
branch
from
e6d5aca to
4bec50e
Compare
eileenmcnaughton
force-pushed
the
master
branch
from
61be107 to
8c90564
Compare
https://civicrm.org/blog/totten/civix-v2205-how-remove-million-lines-extra-code Note I incremented the supported version rather than commit the mixin folder - the old release will stil be there for older sites & current ESR and the current security release do not need it so makes sense to phase out older code
eileenmcnaughton
force-pushed
the
master
branch
from
529d72d to
e25a1dc
Compare
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Sep 22, 2022
This means our code is a match for upstream plus these patches JohnFF/Email-Amender#9 Bug: T318304 Change-Id: Ie3150b179832d1ca96b16d482a880376b280868a
This is post-tagging, so any changes from now are in 3.3.1 (ie increment immediately after release is better than what I normally do)g
Needs the argument values for crmScript quoted now
Fix settings template for Smarty 3
Update to CiviCRM jQuery to work with standalone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm evaluating this for our use & these are a couple of minor bits of cleanup - remove a line of debug & update the civix-generated code