Skip to content

Conversation

@klayoutmatthias
Copy link
Collaborator

No description provided.

@klayoutmatthias klayoutmatthias linked an issue Dec 1, 2025 that may be closed by this pull request
@martinjankoehler
Copy link
Contributor

martinjankoehler commented Dec 4, 2025

Hi @klayoutmatthias,

awesome! Thanks for adding that!

I've noticed some issues.

Issue 1: Icons not drawn properly

Steps to reproduce:

  • draw and select box on Metal3.drawing
  • press 'Q' and open the layer list combo box
  • NOTE: icons successfully drawn (that first time)
  • cancel the dialog
  • open again
  • EXPECTED: icons again successfully drawn
  • OBTAINED: icons appear mostly white

Bildschirmfoto 2025-12-04 um 16 38 26

Issue 2: layer selection does not get applied

Steps to reproduce:

  • draw and select box on Metal3.drawing
  • press 'Q' and open the layer list combo box
  • choose Metal4.drawing
  • click OK
  • EXPECTED: box now on Metal4.drawing
  • OBTAINED: box still on Metal3.drawing

Also, I encountered the issue at some point that the combo box selection was not applied,
but rather re-set on Metal3.drawing

Made a video:

Layer-Combobox-No-Change

@klayoutmatthias
Copy link
Collaborator Author

Very good. Thanks for testing!

Turns out there was some serious architectural rework needed (I told you it's not easy). I uploaded new commits. If you find the time, please give it some test. For me it works well now.

Best regards,

Matthias

@martinjankoehler
Copy link
Contributor

Thanks for the fix! Just tested,

  1. layer switching works now
  2. the icon drawing problem is still the same

Bildschirmfoto 2025-12-05 um 16 44 14

@martinjankoehler
Copy link
Contributor

Beim ersten Öffnen sind alle Icons kaputt, außer dem des effektiven Layers:

Bildschirmfoto 2025-12-10 um 05 33 18

Wählt man was andres aus, oder öffnet den Dialog erneut wie vorher, dann sind die Icons wieder alle dahin:
Bildschirmfoto 2025-12-10 um 05 35 14

@klayoutmatthias
Copy link
Collaborator Author

klayoutmatthias commented Dec 10, 2025 via email

@martinjankoehler
Copy link
Contributor

@klayoutmatthias ja, links im Baum stimmen die Icons, auch bei ~500 Elementen in der Selektion

@stefanottili
Copy link

stefanottili commented Dec 10, 2025

I can't reproduce the problem when not using a technology.
With or without -l my.lyp, klayout shows the icons in the drop down menu for me the first time around.
self-compiled M1 Tahoe qt5

@klayoutmatthias
Copy link
Collaborator Author

I just noticed we switched to German / Austrian :)

I pushed a commit which I hope fixes the problem now. There was a place where the image for the icon wasn't copied by Qt. So basically the image is free'd memory. That would explain, why it can be reproduced occasionally only.

Thanks for testing! :)

Matthias

@martinjankoehler
Copy link
Contributor

Now it works:
Bildschirmfoto 2025-12-10 um 21 53 19

Before I still had the issue (even rebuilt from scratch, which I retested after @stefanottili comment).

@klayoutmatthias klayoutmatthias merged commit 6ad326e into master Dec 11, 2025
26 of 27 checks passed
@klayoutmatthias klayoutmatthias deleted the issue-2224 branch December 11, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Object Properties should allow layer change

4 participants