-
Notifications
You must be signed in to change notification settings - Fork 22
Update bindgen to v0.69.4 to fix building on clang18 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello folks, I noticed this change wasn't merged, but it is necessary for this project to function on Ubuntu 24.04. Also this diff code is required, otherwise libbinder_ndk isn't built. --- a/binder_ndk_sys/build.rs
+++ b/binder_ndk_sys/build.rs
@@ -17,6 +17,8 @@ rust-version = "1.67"
[lib]
crate-type = ["cdylib"]
+
+[workspace]
"#;
fn build_stub() -> Result<()> {So, is this project still alive? Do you need a help maintaining it? I would be happy to participate. |
|
Traverse-Research@41045c6 - this commit also fails @rsglobal just notice that Google engineers have published their upstream codebase to crates.io: rust-mobile/ndk#490 (comment) That is the same codebase that this project was originally copied from (and furthermore never updated/maintained), but this was never mentioned in the README. |
|
Hi @MarijnS95 , It is nice to see you here. I looked at the links you sent me and noticed the description While this project has a different approach, which allows runtime linking with /vendor/lib{64}/libbinder_ndk.so And it looks like maintainers abandoned it, which is sad. |
|
@rsglobal nice to see you here too, seems our Android interests stay aligned and extend to Rust too. Yes, those bindings are what the The symbols are there but cannot be dynamically linked at build-time, but they're found at runtime. It's unfortunate to have two crates with ~exactly the same Rust code just to be able to change what and how it's linked. At runtime you might get away with |
…ing generation `binder_ndk_sys` was implicitly inheriting `workspace.package` fields from the root workspace. This caused Cargo to override the crate's own package configuration and interfered with its custom build logic, leading to incorrect fallback behavior and preventing libbinder_ndk from being generated. Adding an explicit `[workspace]` section makes `binder_ndk_sys` a standalone workspace root, disabling inheritance and restoring the expected build process. This fixes build failures observed on Ubuntu 24.04 and other environments. Ref: Kernel-SU#9 (comment) Signed-off-by: Prslc <prslc113@gmail.com>
No description provided.