-
Notifications
You must be signed in to change notification settings - Fork 124
Clear clReImportSemaphoreSyncKhr semantics for use after signal/wait #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clear clReImportSemaphoreSyncKhr semantics for use after signal/wait #1454
Conversation
| be imported. | ||
| The semaphore _sema_object_ must have originally imported an external handle | ||
| of type {CL_SEMAPHORE_HANDLE_SYNC_FD_KHR}. | ||
| Calling {clReImportSemaphoreSyncFdKHR} when the last operation performed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2025/09/16 memory TSG teleconference: do we need a more precise definition of what constitutes performing an operation? Is a query an operation? Does "perform[ing]" mean executing a command or enqueuing a command? This needs to be clarified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this context "perform" covers both enqueue and execution. We are open to proposals that would help to clarify the meaning of the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to refer to the queried value for CL_SEMAPHORE_PAYLOAD_KHR here? This isn't sufficient to cover cases where the semaphore has pending signals or waits enqueued, so perhaps additional text is still required, but if the (binary) semaphore payload is zero to indicate that it is in the un-signaled state then I think it is a more precise way of saying "the last operation performed on sema_object was a wait".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We believe that referring to the queried value might not be enough due to possible pending signals and waits. We are leaning towards a condition like:
"The last enqueued command to reference the semaphore should be clEnqueueWaitSemaphoresKHR and the semaphore should be in the un-signaled state."
Co-authored-by: Kévin Petit <kpet@free.fr>
Fixes #1407
Currently the spec doesn't specify what would be the behavior if you call clReImportSemaphoreSyncKhr after signaling or importing that semaphore.
As it is stated that "Calling clReImportSemaphoreSyncFdKHR is equivalent to destroying sema_object and re-creating it with the original sema_props from clCreateSemaphoreWithPropertiesKHR", this PR requires an interleaving wait, so no semaphore payload is left behind.