Skip to content

Conversation

@joselopeqti
Copy link
Contributor

Fixes #1407

Currently the spec doesn't specify what would be the behavior if you call clReImportSemaphoreSyncKhr after signaling or importing that semaphore.
As it is stated that "Calling clReImportSemaphoreSyncFdKHR is equivalent to destroying sema_object and re-creating it with the original sema_props from clCreateSemaphoreWithPropertiesKHR", this PR requires an interleaving wait, so no semaphore payload is left behind.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2025

CLA assistant check
All committers have signed the CLA.

be imported.
The semaphore _sema_object_ must have originally imported an external handle
of type {CL_SEMAPHORE_HANDLE_SYNC_FD_KHR}.
Calling {clReImportSemaphoreSyncFdKHR} when the last operation performed on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025/09/16 memory TSG teleconference: do we need a more precise definition of what constitutes performing an operation? Is a query an operation? Does "perform[ing]" mean executing a command or enqueuing a command? This needs to be clarified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context "perform" covers both enqueue and execution. We are open to proposals that would help to clarify the meaning of the text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to refer to the queried value for CL_SEMAPHORE_PAYLOAD_KHR here? This isn't sufficient to cover cases where the semaphore has pending signals or waits enqueued, so perhaps additional text is still required, but if the (binary) semaphore payload is zero to indicate that it is in the un-signaled state then I think it is a more precise way of saying "the last operation performed on sema_object was a wait".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We believe that referring to the queried value might not be enough due to possible pending signals and waits. We are leaning towards a condition like:
"The last enqueued command to reference the semaphore should be clEnqueueWaitSemaphoresKHR and the semaphore should be in the un-signaled state."

Co-authored-by: Kévin Petit <kpet@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear semantics of clReImportSemaphoreSyncFdKHR in regards to clEnqueueWaitSemaphoresKHR and clEnqueueSignalSemaphoresKHR

4 participants