Skip to content

Conversation

@Thaleszh
Copy link
Contributor

Description

Adds json files needed for cosmos chainlist

Type of change

  • Documentation (updates documentation on the project)

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

Walkthrough

Adds three new JSON manifests under testnet_oro/chainlist for the Kiitestnet Oro network:

  • assetlist.json: an asset list with one sdk.coin entry (KII) including base/display denoms, exponents, metadata (name, symbol, type_asset), logo URI, and $schema reference.
  • chain.json: full chain configuration for kiitestnetoro including chain metadata (name, chain_id, bech32_prefix, status), daemon/node settings, codebase details (repo, versions, consensus/SDK info, cosmwasm), seeds/peers, RPC/REST/GRPC/EVM endpoints, explorer template, logo URI, and $schema reference.
  • versions.json: a versions manifest with a single entry (v5.0.0) listing compatible versions, consensus (cometbft 0.38), SDK (cosmos 0.53), CosmWasm enabled, and $schema reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes a brief summary and correctly identifies the change type, but it omits the required testing section and lacks context, motivation, related issue references, and any dependency information as specified by the repository template. Please expand the description to include a “How Has This Been Tested?” section with test details and checkboxes, provide relevant motivation and context, reference any related issues, and list any dependencies required for the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes the primary change of adding Cosmos chainlist information, focusing on the main update without extraneous details or vagueness.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/chainlist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
testnet_oro/chainlist/chain.json (1)

116-119: Normalize the explorer account URL.

There’s an extra slash in https://explorer.kiichain.io//account/${accountAddress}. Most servers tolerate it, but trimming to a single slash avoids surprises.

-      "account_page": "https://explorer.kiichain.io//account/${accountAddress}"
+      "account_page": "https://explorer.kiichain.io/account/${accountAddress}"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between faa2576 and b17dce2.

⛔ Files ignored due to path filters (1)
  • testnet_oro/chainlist/images/kii_oro.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • testnet_oro/chainlist/assetlist.json (1 hunks)
  • testnet_oro/chainlist/chain.json (1 hunks)
  • testnet_oro/chainlist/versions.json (1 hunks)

Copy link
Collaborator

@jhelison jhelison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be fine with the testnet_oro on the path (worried with the _)? A few assets also has references to https://raw.githubusercontent.com/cosmos/chain-registry/master/testnets/kiitestnet on which has a different pathing

Thaleszh and others added 6 commits October 13, 2025 16:22
Co-authored-by: Jhelison Uchoa <68653689+jhelison@users.noreply.github.com>
Co-authored-by: Jhelison Uchoa <68653689+jhelison@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

♻️ Duplicate comments (1)
testnet_oro/chainlist/chain.json (1)

118-118: Fix double slash in explorer account_page URL.

Current link will render as //account/...; use a single slash.

-      "account_page": "https://explorer.kiichain.io//account/${accountAddress}"
+      "account_page": "https://explorer.kiichain.io/account/${accountAddress}"
🧹 Nitpick comments (2)
testnet_oro/chainlist/chain.json (2)

67-67: Consider adding persistent_peers for resiliency.

You already advertise two seeds. Adding them as persistent peers improves node connectivity and bootstrapping.

-    "persistent_peers": []
+    "persistent_peers": [
+      {
+        "id": "5b6aa55124c0fd28e47d7da091a69973964a9fe1",
+        "address": "uno.sentry.testnet.v3.kiivalidator.com:26656",
+        "provider": "Kiichain"
+      },
+      {
+        "id": "5e6b283c8879e8d1b0866bda20949f9886aff967",
+        "address": "dos.sentry.testnet.v3.kiivalidator.com:26656",
+        "provider": "Kiichain"
+      }
+    ]

51-52: Pin genesis_url to a commit SHA for immutability
Branch refs can change; replace the main ref with a specific commit SHA to lock the file:

- "genesis_url": "https://raw.githubusercontent.com/KiiChain/testnets/refs/heads/main/testnet_oro/genesis.json"
+ "genesis_url": "https://raw.githubusercontent.com/KiiChain/testnets/<commit-sha>/testnet_oro/genesis.json"

HEAD check confirms the current URL is reachable (HTTP 200).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1adc149 and f2c17fa.

📒 Files selected for processing (1)
  • testnet_oro/chainlist/chain.json (1 hunks)
🔇 Additional comments (2)
testnet_oro/chainlist/chain.json (2)

3-3: chain_name consistently set to "kiitestnetoro" across chain.json, versions.json, and assetlist.json.


70-110: Endpoints validated — RPC endpoints returned HTTP/2 200, LCD endpoints returned 501 to HEAD (host reachable), JSON-RPC endpoints returned 405 to HEAD (host reachable), gRPC hostnames resolve correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants