Use a login shell for scriptlets to pick up reasonable PATH #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts currently run without `PATH` set at all. This works somewhat okay for things directly launched within these scripts, because busybox defaults to PATH=/sbin:/usr/sbin:/bin:/usr/bin for anything run in the script -- it's not set as an environment variable though, so it doesn't propagate to subprocesses. This means directly running sh, eips, etc. will work fine, but any processes started (e.g. a daemon like utild) will have an unexpectedly empty PATH. This changes `sh` to be invoked with `-l` (`--login`), which will execute `/etc/profile` and set the usual PATH.
Member
|
Tests pass, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts currently run without
PATHset at all.This works somewhat okay for things directly launched within these scripts, because busybox defaults to
PATH=/sbin:/usr/sbin:/bin:/usr/bin(source) for anything run in the script -- it's not set as an environment variable though, so it doesn't propagate to subprocesses.This means directly running sh, eips, etc. will work fine, but any processes started (e.g. a daemon like utild) will have an unexpectedly empty PATH.
This changes
shto be invoked with-l(--login), which will execute/etc/profileand set the usual PATH.