Skip to content

Conversation

Copy link

Copilot AI commented Nov 14, 2025

Steam games parsed from .acf manifest files displayed no platform tag in the UI while games from other sources (Epic, GOG, Xbox) correctly showed their platform identifiers.

Changes

  • src/scanner/game_scanner.py: Added missing platform='Steam' parameter to Game object creation in _parse_steam_acf method (line 661)
  • tests/test_game_platform_tags.py: Added test coverage verifying platform attribute behavior and ACF parsing

Example

# Before: platform parameter omitted, defaults to None
return Game(name=name, path=str(game_path), appid=appid, 
            image_path=image_path, optiscaler_installed=optiscaler_installed,
            engine=safety['engine'], anti_cheat_list=safety['anti_cheat_list'],
            community_verified=safety['community_verified'], 
            engine_supported=safety.get('engine_supported', True))

# After: platform explicitly set
return Game(name=name, path=str(game_path), appid=appid, 
            image_path=image_path, optiscaler_installed=optiscaler_installed,
            engine=safety['engine'], anti_cheat_list=safety['anti_cheat_list'],
            community_verified=safety['community_verified'], 
            engine_supported=safety.get('engine_supported', True),
            platform='Steam')

The Game class already supported the platform attribute; other scanning methods (_scan_epic_games, _scan_gog_games, etc.) were setting it correctly. This was the only location missing the parameter.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.steampowered.com
    • Triggering command: python -m pytest tests/test_game_platform_tags.py::test_parse_steam_acf_sets_platform -v (dns block)
    • Triggering command: python -m pytest tests/test_game_platform_tags.py -v (dns block)
    • Triggering command: python -m pytest tests/ -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt
  1. not all games have installer tags like Steam or gog. why ?

User has selected text in file tests/test_steam_vdf_parsing.py from 35:26 to 35:55

Summary of Conversation History

User Goals

The user has been focused on improving the functionality and user interface of the OptiScaler-GUI application. They expressed concerns about various aspects of the application, including UI performance, missing images, and the presence of unnecessary debug information. The user also indicated a desire to publish a new release of the application and bump the version number to 0.3.6.

Recent Agent Commands and Tool Results

  1. User Request: "I do not like the different missing images. 1. investigate why they are missing 2. make a missing img frame that is the same size as the real images."

    • Context: The user is asking for an investigation into missing images and a solution to create placeholder frames for these images.
  2. User Request: "not all games have installer tags like Steam or gog. why?"

    • Context: The user is inquiring about the absence of installer tags for certain games, indicating a need for clarification on how the application categorizes games.

Recent Operations

  • The agent was actively working on addressing the user's concerns about missing images and the categorization of games when the token budget was exceeded. The user had previously expressed frustration with the application's UI and functionality, indicating a need for improvements and clarifications.

Connection to Overall User Goals

The recent operations are directly connected to the user's overarching goals of enhancing the application’s usability and performance. The user is seeking to ensure that the application provides a consistent and functional experience, particularly regarding the display of game information and the presence of necessary tags. Additionally, the user is looking to finalize a new release, which emphasizes the importance of resolving these issues promptly.
TITLE: Missing installer tags for some games

Created from VS Code via the GitHub Pull Request extension.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits November 14, 2025 21:24
Co-authored-by: King4s <14319716+King4s@users.noreply.github.com>
Co-authored-by: King4s <14319716+King4s@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate missing installer tags in game database Fix missing platform tags for Steam games parsed from ACF files Nov 14, 2025
Copilot AI requested a review from King4s November 14, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants