Improve query plans for test measurement GraphQL field #3318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
test-measurements-graphql-performance
branch
from
454c841 to
9cca190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our GraphQL backend, Lighthouse, currently requires fields using relay-style pagination to specify a limit or fall back to the default limit. This creates extremely inefficient queries when nested paginated fields are used, leading to substantial slowness on the new tests page. It's very unlikely that any CDash users will actually want to paginate test measurement results, so this PR makes the field non-paginated and adds the necessary infrastructure to the filtering system to handle such fields. It would be beneficial to upstream a change to Lighthouse to allow unlimited results for paginated fields.